[Bug 1823872] Re: Fixing fsfreeze-hook can break unattended upgrades

[Christian Ehrhardt ]

Fix might be in qemu (add even more special cases) or in unattended
upgrades (to properly handle or at least not die). Added a bug task for
that.

** Description changed:

  As reported on https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1820291/comments/20
  We fixed an issue and we added workrounds since basic mv_conffile coudn't handle it and did all sort of upgrade tests.
  
  That all worked fine and moved the conffile.
  
  It was now reported that due to some pre-checks that unattended upgrades
  might do this might do some checks on its own.
  
  Next step:
  - check unattended upgrades through this change
  - check if it only affects cases were the former config was modified (minority) or the default file layout (majority)
+ 
+ 
+ --- original report copied ---
+ 
+ just wanted to add: This bug also crashes unattended-upgrade and thus
+ prevents security updates on 18.04:
+ 
+ root at mailin1:~# unattended-upgrade
+ Traceback (most recent call last):
+   File "/usr/bin/unattended-upgrade", line 1998, in <module>
+     sys.exit(main(options))
+   File "/usr/bin/unattended-upgrade", line 1714, in main
+     if conffile_prompt(item.destfile):
+   File "/usr/bin/unattended-upgrade", line 929, in conffile_prompt
+     with open(prefix + conf_file, 'rb') as fp:
+ IsADirectoryError: [Errno 21] Is a directory: '/etc/qemu/fsfreeze-hook'
+ 
+ Basically, unattended-upgrade wants to compare old/new conffiles and
+ doesn't like it when the old conffile turns out to be a directory...
+ 
+ This prevents security updates to be installed. The unattended-upgrade
+ logs do not contain the trace, only the messages:
+ 
+ 2019-04-05 13:24:24,851 INFO Initial blacklisted packages:
+ 2019-04-05 13:24:24,853 INFO Initial whitelisted packages:
+ 2019-04-05 13:24:24,853 INFO Starting unattended upgrades script
+ 2019-04-05 13:24:24,854 INFO Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic'
+ 
+ And that's it.
+ 
+ You can't really get out of this without manually running 'apt-get
+ install qemu-guest-agent' because at this point, unattended-upgrade
+ can't update itself anymore.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1823872

Title:
  Fixing fsfreeze-hook can break unattended upgrades

Status in qemu package in Ubuntu:
  New
Status in unattended-upgrades package in Ubuntu:
  New

Bug description:
  As reported on https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1820291/comments/20
  We fixed an issue and we added workrounds since basic mv_conffile coudn't handle it and did all sort of upgrade tests.

  That all worked fine and moved the conffile.

  It was now reported that due to some pre-checks that unattended
  upgrades might do this might do some checks on its own.

  Next step:
  - check unattended upgrades through this change
  - check if it only affects cases were the former config was modified (minority) or the default file layout (majority)

  
  --- original report copied ---

  just wanted to add: This bug also crashes unattended-upgrade and thus
  prevents security updates on 18.04:

  root at mailin1:~# unattended-upgrade
  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrade", line 1998, in <module>
      sys.exit(main(options))
    File "/usr/bin/unattended-upgrade", line 1714, in main
      if conffile_prompt(item.destfile):
    File "/usr/bin/unattended-upgrade", line 929, in conffile_prompt
      with open(prefix + conf_file, 'rb') as fp:
  IsADirectoryError: [Errno 21] Is a directory: '/etc/qemu/fsfreeze-hook'

  Basically, unattended-upgrade wants to compare old/new conffiles and
  doesn't like it when the old conffile turns out to be a directory...

  This prevents security updates to be installed. The unattended-upgrade
  logs do not contain the trace, only the messages:

  2019-04-05 13:24:24,851 INFO Initial blacklisted packages:
  2019-04-05 13:24:24,853 INFO Initial whitelisted packages:
  2019-04-05 13:24:24,853 INFO Starting unattended upgrades script
  2019-04-05 13:24:24,854 INFO Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic'

  And that's it.

  You can't really get out of this without manually running 'apt-get
  install qemu-guest-agent' because at this point, unattended-upgrade
  can't update itself anymore.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1823872/+subscriptions