[Bug 1713690] Re: Restore /usr/share/doc/contrib/diff-highlight/diff-highlight

[Adam Conrad]

** Description changed:

- This was removed in my most recent upgrade on artful, 1:2.11.0-4 ->
- 1:2.14.1-1ubuntu3.
+ [ SRU Verification ]
+ This is just a papercut, but diff-highlight was shipped built in the past (including in xenial), so dropping it in bionic was a regression.
+ 
+ [ Regression Potential ]
+ None, this is just shipping a built perl script in doc.
+ 
+ [ Test Case ]
+ Check that the file is now shipped and works when specific in the [pager] section as shown in the bug report.
+ 
+ [ Original Report ]
+ This was removed in my most recent upgrade on artful, 1:2.11.0-4 -> 1:2.14.1-1ubuntu3.
  
  This is particularly frustrating as it caused a bunch of git operations
  to start erroring for me, as I have the following in my .gitconfig:
  
  [pager]
- 	diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
- 	log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
- 	show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
+  diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
+  log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
+  show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less

** Description changed:

  [ SRU Verification ]
  This is just a papercut, but diff-highlight was shipped built in the past (including in xenial), so dropping it in bionic was a regression.
  
  [ Regression Potential ]
  None, this is just shipping a built perl script in doc.
  
  [ Test Case ]
- Check that the file is now shipped and works when specific in the [pager] section as shown in the bug report.
+ Check that the file is now shipped and works when specified in the [pager] section as shown in the bug report.
  
  [ Original Report ]
  This was removed in my most recent upgrade on artful, 1:2.11.0-4 -> 1:2.14.1-1ubuntu3.
  
  This is particularly frustrating as it caused a bunch of git operations
  to start erroring for me, as I have the following in my .gitconfig:
  
  [pager]
   diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to git in Ubuntu.
https://bugs.launchpad.net/bugs/1713690

Title:
  Restore /usr/share/doc/contrib/diff-highlight/diff-highlight

Status in git package in Ubuntu:
  Confirmed
Status in git source package in Bionic:
  Fix Committed
Status in git package in Debian:
  New

Bug description:
  [ SRU Verification ]
  This is just a papercut, but diff-highlight was shipped built in the past (including in xenial), so dropping it in bionic was a regression.

  [ Regression Potential ]
  None, this is just shipping a built perl script in doc.

  [ Test Case ]
  Check that the file is now shipped and works when specified in the [pager] section as shown in the bug report.

  [ Original Report ]
  This was removed in my most recent upgrade on artful, 1:2.11.0-4 -> 1:2.14.1-1ubuntu3.

  This is particularly frustrating as it caused a bunch of git
  operations to start erroring for me, as I have the following in my
  .gitconfig:

  [pager]
   diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git/+bug/1713690/+subscriptions