[Bug 1794292] Re: plymouthd crashed with SIGSEGV in /sbin/plymouthd:11 in ply_renderer_set_handler_for_input_source -> ply_keyboard_stop_watching_for_renderer_input -> ply_keyboard_stop_watching_for_input -> ply_device_manager_deactivate_keyboards -> on_deactivate

[Gert van de Kraats]

Proposing next improved code

At src/libply-splash-core/ply-device-manager.c

1) at 
create_devices_for_subsystem (ply_device_manager_t *manager,
                              const char           *subsystem)
change
    found_device = create_devices_for_udev_device (manager, device);
into
    found_device = found_device || create_devices_for_udev_device (manager, device);

2) at
create_devices_for_terminal_and_renderer_type (ply_device_manager_t *manager,
                                               const char           *device_path,
                                               ply_terminal_t       *terminal,
                                               ply_renderer_type_t   renderer_type)
change
   return;
into
   return false;

Notes at 1);
As can be seen at the downloaded grub-trace, the graphical splash with keyboard is activated on 2 screens, 
before the device-timeout (which is set to 10.0).
After the device-timeout  routine create_devices_from_udev will call create_devices_for_subsystem (manager, SUBSYSTEM_DRM). 
This routine should return true if any drm-device is found. Because of the wrong code it returns only true 
if the last device is coorect.
As can be seen at the downloaded grub-trace the last device /dev/dri/renderD128 is not usable. 
This causes at the trace-message: create_devices_from_udev:Creating non-graphical devices, since there's no suitable graphics hardware.
This causes the second unwanted call to create_devices_for_terminal_and_renderer_type for non-graphical /dev/tty1, also listening to keyboard. 

Notes at 2)
This is the solution for a compiler warning. It is just wrong coding, do not know if it will ever harm.

Remark:
For some reason at my PC the drm-devices are comimg up very slow at 18.10 (22 sec) compared to 18.04 (3 sec).
To avoid the ugly text splash I had to enlarge DeviceTimeout from default 5 to 10. This does not slow down startuptime. 
cat /etc/plymouth/plymouthd.conf
# Administrator customizations go in this file
[Daemon]
Theme=solar
ShowDelay=0
DeviceTimeout=10
 

** Attachment added: "plymouth-debug_GK7.log"
   https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1794292/+attachment/5207296/+files/plymouth-debug_GK7.log

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to plymouth in Ubuntu.
https://bugs.launchpad.net/bugs/1794292

Title:
  plymouthd crashed with SIGSEGV in /sbin/plymouthd:11 in
  ply_renderer_set_handler_for_input_source ->
  ply_keyboard_stop_watching_for_renderer_input ->
  ply_keyboard_stop_watching_for_input ->
  ply_device_manager_deactivate_keyboards -> on_deactivate

Status in plymouth package in Ubuntu:
  Confirmed
Status in plymouth source package in Cosmic:
  Confirmed

Bug description:
  A green Xubuntu splash screen with a spinning circle normally appears
  on boot up.

  Now just a blank black screen shows until the login box appears. On
  logging in, the desktop appears as normal but an error message pops up
  offering to report a bug to developers.

  Description:	Ubuntu Cosmic Cuttlefish (development branch)
  Release:	18.10

  All packages up-to-date as of 25 September 2018 14:00 BST

  
  Errors Tracker: https://errors.ubuntu.com/problem/6aa06f1bc51946c787a01d38e58bc76114555334

  
  ProblemType: Crash
  DistroRelease: Ubuntu 18.10
  Package: plymouth 0.9.3-1ubuntu8
  ProcVersionSignature: Ubuntu 4.18.0-7.8-generic 4.18.5
  Uname: Linux 4.18.0-7-generic x86_64
  ApportVersion: 2.20.10-0ubuntu11
  Architecture: amd64
  CrashCounter: 1
  Date: Tue Sep 25 13:47:47 2018
  DefaultPlymouth: /usr/share/plymouth/themes/xubuntu-logo/xubuntu-logo.plymouth
  ExecutablePath: /sbin/plymouthd
  MachineType: Acer Veriton N280G
  ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.18.0-7-generic root=UUID=ff708f10-3fbc-4fa2-b7a5-93f0dd61eb21 ro splash quiet vt.handoff=1
  ProcCmdline: @sbin/plymouthd --mode=boot --pid-file=/run/plymouth/pid --attach-to-session
  ProcEnviron:
   LANG=en_GB.UTF-8
   PATH=(custom, no user)
  ProcFB: 0 inteldrmfb
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.18.0-7-generic root=UUID=ff708f10-3fbc-4fa2-b7a5-93f0dd61eb21 ro splash quiet vt.handoff=1
  SegvAnalysis:
   Segfault happened at: 0x7f05452a07f9 <ply_renderer_set_handler_for_input_source+25>:	mov    0x78(%rax),%rax
   PC (0x7f05452a07f9) ok
   source "0x78(%rax)" (0x00000078) not located in a known VMA region (needed readable region)!
   destination "%rax" ok
  SegvReason: reading NULL VMA
  Signal: 11
  SourcePackage: plymouth
  StacktraceTop:
   ply_renderer_set_handler_for_input_source () from /lib/x86_64-linux-gnu/libply-splash-core.so.4
   ply_keyboard_stop_watching_for_input () from /lib/x86_64-linux-gnu/libply-splash-core.so.4
   ply_device_manager_deactivate_keyboards () from /lib/x86_64-linux-gnu/libply-splash-core.so.4
   ?? ()
   ?? ()
  TextPlymouth: /usr/share/plymouth/themes/xubuntu-text/xubuntu-text.plymouth
  Title: plymouthd crashed with SIGSEGV in ply_renderer_set_handler_for_input_source()
  UpgradeStatus: Upgraded to cosmic on 2018-08-21 (34 days ago)
  UserGroups:

  dmi.bios.date: 01/15/2011
  dmi.bios.vendor: Acer
  dmi.bios.version: P01-A3
  dmi.board.asset.tag: To Be Filled By O.E.M.
  dmi.board.name: TPDS03
  dmi.board.vendor: Acer
  dmi.board.version: To be filled by O.E.M.
  dmi.chassis.type: 3
  dmi.chassis.vendor: Acer
  dmi.chassis.version: To Be Filled By O.E.M.
  dmi.modalias: dmi:bvnAcer:bvrP01-A3:bd01/15/2011:svnAcer:pnVeritonN280G:pvrToBeFilledByO.E.M.:rvnAcer:rnTPDS03:rvrTobefilledbyO.E.M.:cvnAcer:ct3:cvrToBeFilledByO.E.M.:
  dmi.product.family: Acer Desktop
  dmi.product.name: Veriton N280G
  dmi.product.sku: To Be Filled By O.E.M.
  dmi.product.version: To Be Filled By O.E.M.
  dmi.sys.vendor: Acer

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1794292/+subscriptions