[Bug 1766872] Please test proposed package

[Łukasz Zemczak]

Hello Eric, or anyone else affected,

Accepted friendly-recovery into bionic-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/friendly-
recovery/0.2.38ubuntu1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to friendly-recovery in Ubuntu.
https://bugs.launchpad.net/bugs/1766872

Title:
  'Enable Network' in recovery mode not working properly.

Status in friendly-recovery package in Ubuntu:
  Fix Released
Status in systemd package in Ubuntu:
  Won't Fix
Status in friendly-recovery source package in Xenial:
  In Progress
Status in systemd source package in Xenial:
  Won't Fix
Status in friendly-recovery source package in Bionic:
  Fix Committed
Status in systemd source package in Bionic:
  Won't Fix
Status in friendly-recovery source package in Cosmic:
  Fix Released
Status in systemd source package in Cosmic:
  Won't Fix
Status in friendly-recovery source package in DD-Series:
  Invalid
Status in systemd source package in DD-Series:
  Won't Fix

Bug description:
  [Impact]

   * network menu in recovery mode doesn't work correctly, blocking at
  starting systemd services depends to enable networking.

  [Test Case]

   * Boot w/ Xenial or Bionic in recovery mode via grub
   * Choose "network" in friendly-recovery menu

   The network won't be activated and it'll be stuck at systemd-tty-ask-
  password :

  # pstree
  systemd-+-bash---pstree
          |-recovery-menu---network---systemctl---systemd-tty-ask

  [Regression Potential]

  * Low.
  * All options works fine.
  * Cosmic has the same changes already in place.

  * According to xnox, resume option fails to boot now.
  After verification the 'resume' has the same effect before/after that change, it boots up but still seems to stick in 'recovery' option according to /proc/cmdline so I don't see any obvious behaviour change before and after.

  [Other Info]

   * Upstream :
  https://bazaar.launchpad.net/~ubuntu-core-dev/friendly-recovery/ubuntu/changes/161?start_revid=161
  Revision  154 to 161

  [Original Description]

  This bug has been noticed after the introduction of the fix of (LP:
  #1682637) in Bionic.

  I have notice a block in Bionic when choosing 'Enable Network' option
  in recovery mode on different bionic vanilla system and I can
  reproduce all the time.

  I also asked colleagues to give it a try (for a second pair of eye on
  this) and they have the same result as me.

  Basically, when choosing 'Enable Network' it get block or lock.
  If we hit 'ctrl-c', then a shell arrive and the system has network connectivity.

  Here's what I find while enabling "systemd.debug-shell=1" from vtty9 :

  # pstree
  systemd-+-bash---pstree
          |-recovery-menu---network---systemctl---systemd-tty-ask
          |-systemd-journal
          ....

  # ps
  root 486 473 0 08:29 tty1 00:00:00 /bin/systemd-tty-ask-password-agent

  root 473 486 0 08:29 tty1 00:00:00 systemctl start dbus.socket

  root 486 283 0 08:29 tty1 00:00:00 /bin/sh /lib/recovery-
  mode/options/network

  Additionally,

  systemd-analyze blame:
  "Bootup is not yet finished. Please try again later"

  "systemctl list-jobs" is showing a 100 jobs in 'waiting' state

  The only 'running' unit is friendly-recovery.service :
  52 friendly-recovery.service                 start running

  The rest are all "waiting". My understanding is that "waiting" units
  will be executed only after those which are "running" are completed.
  Which explain why the "ctlr-c" allow the boot to continue.

  All the systemd special unit important at boot-up are waiting.
  7 sysinit.target                 start waiting
  3 basic.target                   start waiting
  .....

  Seems like systemd is not fully initialise in 'Recovery Mode' and
  doesn't allow any 'systemctl start' operation without
  password/passphrase request, which I suspect is hidden by the
  recovery-mode menu.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/friendly-recovery/+bug/1766872/+subscriptions