[Bug 1713690] Re: Restore /usr/share/doc/contrib/diff-highlight/diff-highlight

[Dan Watkins]

On Fri, Oct 12, 2018 at 07:18:51AM -0000, Georgi Georgiev wrote:
> Any reason why the executable bit of diff-highlight is stripped?
> 
> If I run `sudo make -B -C /usr/share/doc/git/contrib/diff-highlight
> diff-highlight` the generated file is executable, but the one shipped
> with the package is not.

My configuration has been the following for a while (albeit commented
out due to this bug), which suggests that it wasn't previously
executable (and also demonstrates how to use it regardless :):

[pager]
	diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight.perl | less
	log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight.perl | less
	show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight.perl | less

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to git in Ubuntu.
https://bugs.launchpad.net/bugs/1713690

Title:
  Restore /usr/share/doc/contrib/diff-highlight/diff-highlight

Status in git package in Ubuntu:
  Fix Committed
Status in git source package in Bionic:
  Fix Released
Status in git package in Debian:
  New

Bug description:
  [ SRU Verification ]
  This is just a papercut, but diff-highlight was shipped built in the past (including in xenial), so dropping it in bionic was a regression.

  [ Regression Potential ]
  None, this is just shipping a built perl script in doc.

  [ Test Case ]
  Check that the file is now shipped and works when specified in the [pager] section as shown in the bug report.

  [ Original Report ]
  This was removed in my most recent upgrade on artful, 1:2.11.0-4 -> 1:2.14.1-1ubuntu3.

  This is particularly frustrating as it caused a bunch of git
  operations to start erroring for me, as I have the following in my
  .gitconfig:

  [pager]
   diff = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   log = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less
   show = perl /usr/share/doc/git/contrib/diff-highlight/diff-highlight | less

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/git/+bug/1713690/+subscriptions