[Bug 1797209] Re: do-release-upgrade should block release upgrades in some circumstances
Brian Murray
brian at ubuntu.com
Thu Oct 11 17:45:17 UTC 2018
On Thu, Oct 11, 2018 at 09:41:42AM -0000, Iain Lane wrote:
> I saw this in the unapproved queue and have the following questions:
>
> What's the reason for singling out the libc6 reboot-required reason
> rather than asking for *any* reboot-required?
At the end of the release upgrade you'll be required to reboot anyway so
it seemed redundant to have people reboot because evolution-data-server
or the kernel were upgraded when they'll have to reboot after the
upgrade.
> If you do strongly want to keep it limited to libc6 only, wouldn't
> opening the file in the python code instead of opening a grep subprocess
> be faster?
Ah yeah, I'll do that.
> I'm semi-convinced by your reasoning on untranslated strings, but if we
> could make some effort towards getting as many as possible I'd be
> happier, such as mailing the translator list so it gets in the next
> langpack refresh in bionic. (And it seems to me like if the string could
> avoid mentioning "libc6" that would be more friendly to any future
> tweaks in this area.)
Okay, I'll make the error message more generic.
> Is it right to say that this could equally be a 0-day SRU and so this
> upload isn't important for the release itself - there's no need to rush
> it in for final freeze?
Yes, that's true but we really need to fix it in Ubuntu 18.04 as
do-release-upgrade is run from the package on the system being upgraded
and not from the dist-upgrader tarball. So even if its not accepted
right now I think the SRU team would appreciate a we'll accept this as a
0-day SRU comment.
--
Brian Murray
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1797209
Title:
do-release-upgrade should block release upgrades in some circumstances
Status in ubuntu-release-upgrader package in Ubuntu:
In Progress
Status in ubuntu-release-upgrader source package in Xenial:
New
Status in ubuntu-release-upgrader source package in Bionic:
New
Status in ubuntu-release-upgrader source package in Cosmic:
In Progress
Bug description:
Impact
------
do-release-upgrade will allow people to upgrade to a new release of Ubuntu even if they have outstanding updates to install or need to reboot from a libc6 upgrade. This behavior is different than that of update-manager which forces you to install all updates or reboot before upgrading. Additionally, this specifically allows users to upgrade without receiving fixes that would improve the upgrade process e.g. bug 1780996.
Test Case for missing updates
-----------------------------
1) Install Ubuntu 18.04 and don't install updates.
2) Modify /etc/update-manager/release-upgrades so Prompt=normal
3) Run 'do-release-upgrade -d'
With the current version of ubuntu-release-upgrader-core you'll be
able to upgrade to Ubuntu 18.10, with the version from -proposed
you'll receive a message saying "Please install all available updates
for your release before upgrading."
Test Case for libc6 update
--------------------------
1) Install Ubuntu 18.04
2) Modify /etc/update-manager/release-upgrades so Prompt=normal
3) Run 'sudo apt-get install --reinstall libc6'
4) Run 'do-release-upgrade -d'
With the current version of ubuntu-release-upgrader-core you'll be
able to upgrade to Ubuntu 18.10, with the version from -proposed
you'll receive a message saying "You have not rebooted after a
previous libc6 update. Please reboot before upgrading."
Regression Potential
--------------------
The strings are not translated but that seems better than people having a bad outcome when upgrading. It's also worth noting that
/usr/lib/ubuntu-release-upgrader/release-upgrade-motd calls /usr/lib/ubuntu-release-upgrader/check-new-release to write a stamp file which contains information about the availability of a release upgrade. The behavior of check-new-release should be the same i.e. it should say a new release is available and not mention the need to install updates or reboot. This can be tested by running '/usr/lib/ubuntu-release-upgrader/check-new-release -qcd'. The output should contain "New release ... available ... use do-release-upgrade".
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1797209/+subscriptions
More information about the foundations-bugs
mailing list