[Bug 1794936] Re: new gccgo version update (4:8.2.0-1ubuntu2.1) is triggering dh-golang <1.35 bug

[Robie Basak]

The dh-golang SRU needs a proper Regression Potential section please.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to dh-golang in Ubuntu.
https://bugs.launchpad.net/bugs/1794936

Title:
  new gccgo version update (4:8.2.0-1ubuntu2.1)  is triggering dh-golang
  <1.35 bug

Status in dh-golang package in Ubuntu:
  Fix Released
Status in gcc-8 package in Ubuntu:
  Invalid
Status in dh-golang source package in Bionic:
  In Progress
Status in gcc-8 source package in Bionic:
  New

Bug description:
  [impact]
  Packages that use gccgo-go to build fail to build. There aren't really any such packages in Ubuntu today, but it's still a broken situation.

  [test case]
  $ apt source golang-petname
  $ cd golang-petname-*/
  $ sed -i -e 's/golang-go/gccgo-go/' debian/control
  $ apt build-dep ./
  $ dpkg-buildpackage

  [regression potential]
  It's just a small patch from Debian, so very slight. It's caused no problems in Debian or cosmic.

  [original description]
  We see this kind of error in recent runs of snapd tests when using bionic updating gccgo 4:8.2.0-1ubuntu2.1 and current dh-golang 1.34.

  Can be run  from snapd master checkout with:

  spread -v -debug google:ubuntu-18.04-64:tests/unit/gccgo

  with the proper configuration.

  Error:

  ...
    dh_makeshlibs -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
     dh_shlibdeps -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
     debian/rules override_dh_installdeb
  make[1]: Entering directory '/home/gopath/src/github.com/snapcore/snapd'
  dh_apparmor --profile-name=usr.lib.snapd.snap-confine.real -psnapd
  dh_installdeb
  make[1]: Leaving directory '/home/gopath/src/github.com/snapcore/snapd'
     dh_golang -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
  template: main:2:14: executing "main" at <index (or .GoFiles ....>: error calling index: index out of range: 0
  dh_golang: go list -f '\
  {{ .Dir }}/{{ index (or .GoFiles .CgoFiles .TestGoFiles .XTestGoFiles .IgnoredGoFiles) 0 }}' returned exit code 1
  debian/rules:103: recipe for target 'binary' failed
  make: *** [binary] Error 1
  dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
  -----

  These were passing until today.

  Seems related/similar to https://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=907263

  which mentions dh-golang 1.35 having a fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dh-golang/+bug/1794936/+subscriptions