[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do
Scott Moser
ssmoser2+ubuntu at gmail.com
Tue Oct 2 00:26:04 UTC 2018
Here is my verification of bionic proposed.
It should be considered in cooperation with open-iscsi dep8 tests
which do a iscsi root boot:
http://autopkgtest.ubuntu.com/packages/o/open-iscsi/bionic/amd64
Below is sufficient for the 'Test Case' section of the SRU Template,
it would be nice to see an actual user of open-iscsi test this.
### Setup
###
Launched a fresh bionic image of 20180927.
Notes:
* to avoid noise below I have done 'apt-get autoremove' (LP: #1721035)
* The following is 'connect-abstract-socket.py' which is used below.
#!/usr/bin/python3
from socket import socket, AF_UNIX, SOCK_STREAM
import sys
socket(AF_UNIX, SOCK_STREAM).connect(('\0' + sys.argv[1]))
print("Connected to @%s" % sys.argv[1])
### fresh boot of image.
$ cat /etc/cloud/build.info
build_name: server
serial: 20180927
$ dpkg-query --show open-iscsi
open-iscsi 2.0.874-5ubuntu2.1
$ systemctl status --no-pager --full iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; enabled; vendor preset: enabled)
Active: active (running) since Mon 2018-10-01 19:57:30 UTC; 3min 12s ago
Docs: man:iscsid(8)
Process: 764 ExecStart=/sbin/iscsid (code=exited, status=0/SUCCESS)
Process: 728 ExecStartPre=/lib/open-iscsi/startup-checks.sh (code=exited, status=0/SUCCESS)
Main PID: 768 (iscsid)
Tasks: 2 (limit: 2362)
CGroup: /system.slice/iscsid.service
├─767 /sbin/iscsid
└─768 /sbin/iscsid
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator daemon (iscsid)...
Oct 01 19:57:32 bionic-20181001-195627 iscsid[767]: iSCSI daemon with pid=768 started!
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Started iSCSI initiator daemon (iscsid).
$ systemctl status open-iscsi.service --full --no-pager
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Mon 2018-10-01 19:57:30 UTC; 4min 13s ago
├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met
└─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met
Docs: man:iscsiadm(8)
man:iscsid(8)
### Enable proposed
$ line=$(awk '$1 == "deb" && $2 ~ /ubuntu.com/ {
printf("%s %s %s-proposed main universe\n", $1, $2, rel); exit(0) };
' "rel=$rel" /etc/apt/sources.list)
$ echo "$line" | sudo tee /etc/apt/sources.list.d/proposed.list
deb http://nova.clouds.archive.ubuntu.com/ubuntu/ bionic-proposed main universe
$ sudo apt-get update -q
$ apt-cache policy open-iscsi
open-iscsi:
Installed: 2.0.874-5ubuntu2.1
Candidate: 2.0.874-5ubuntu2.2
Version table:
2.0.874-5ubuntu2.2 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
*** 2.0.874-5ubuntu2.1 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
100 /var/lib/dpkg/status
2.0.874-5ubuntu2 500
500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/main amd64 Packages
### Test Case 1
### uninstall before upgrade
$ sudo apt-get --purge remove open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
open-iscsi* ubuntu-server*
0 upgraded, 0 newly installed, 2 to remove and 51 not upgraded.
After this operation, 1461 kB disk space will be freed.
Do you want to continue? [Y/n]
(Reading database ... 59669 files and directories currently installed.)
Removing ubuntu-server (1.417) ...
Removing open-iscsi (2.0.874-5ubuntu2.1) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Processing triggers for man-db (2.8.3-2) ...
(Reading database ... 59632 files and directories currently installed.)
Purging configuration files for open-iscsi (2.0.874-5ubuntu2.1) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for systemd (237-3ubuntu10.3) ...
$ sudo apt-get install open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
open-iscsi
0 upgraded, 1 newly installed, 0 to remove and 51 not upgraded.
Need to get 280 kB of archives.
After this operation, 1417 kB of additional disk space will be used.
Get:1 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 op
en-iscsi amd64 2.0.874-5ubuntu2.2 [280 kB]
Fetched 280 kB in 0s (711 kB/s)
Preconfiguring packages ...
Selecting previously unselected package open-iscsi.
(Reading database ... 59627 files and directories currently installed.)
Preparing to unpack .../open-iscsi_2.0.874-5ubuntu2.2_amd64.deb ...
Unpacking open-iscsi (2.0.874-5ubuntu2.2) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
cp: cannot stat '/etc/iscsi/initiatorname.iscsi': No such file or directory
Setting up open-iscsi (2.0.874-5ubuntu2.2) ...
Created symlink /etc/systemd/system/sockets.target.wants/iscsid.socket → /lib/sy
stemd/system/iscsid.socket.
Created symlink /etc/systemd/system/iscsi.service → /lib/systemd/system/open-isc
si.service.
Created symlink /etc/systemd/system/sysinit.target.wants/open-iscsi.service → /l
ib/systemd/system/open-iscsi.service.
Processing triggers for systemd (237-3ubuntu10.3) ...
Processing triggers for man-db (2.8.3-2) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Processing triggers for ureadahead (0.100.0-20) ...
$ systemctl status --no-pager --full iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; disabled; vendor preset: enabled)
Active: inactive (dead) since Mon 2018-10-01 20:15:25 UTC; 2min 33s ago
Docs: man:iscsid(8)
Main PID: 768 (code=exited, status=0/SUCCESS)
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator daemon (iscsid)...
Oct 01 19:57:32 bionic-20181001-195627 iscsid[767]: iSCSI daemon with pid=768 started!
Oct 01 19:57:30 bionic-20181001-195627 systemd[1]: Started iSCSI initiator daemon (iscsid).
Oct 01 20:15:25 bionic-20181001-195627 systemd[1]: Stopping iSCSI initiator daemon (iscsid)...
Oct 01 20:15:25 bionic-20181001-195627 iscsid[767]: iscsid shutting down.
Oct 01 20:15:25 bionic-20181001-195627 systemd[1]: Stopped iSCSI initiator daemon (iscsid).
● iscsid.socket - Open-iSCSI iscsid Socket
Loaded: loaded (/lib/systemd/system/iscsid.socket; enabled; vendor preset: enabled)
Active: active (listening) since Mon 2018-10-01 20:17:15 UTC; 43s ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream)
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 01 20:17:15 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Docs: man:iscsiadm(8)
man:iscsid(8)
## Check what happens after reboot.
## Expect that socket listening and services not running.
$ sudo reboot
$ sudo systemctl status --full --no-pager iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; disabled; vendor preset: enabled)
Active: inactive (dead)
Docs: man:iscsid(8)
● iscsid.socket - Open-iSCSI iscsid Socket
Loaded: loaded (/lib/systemd/system/iscsid.socket; enabled; vendor preset: enabled)
Active: active (listening) since Mon 2018-10-01 21:20:19 UTC; 16s ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream)
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 01 21:20:19 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Mon 2018-10-01 21:20:19 UTC; 16s ago
├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met
└─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met
Docs: man:iscsiadm(8)
man:iscsid(8)
$ sudo ./connect-abstract-socket.py ISCSIADM_ABSTRACT_NAMESPACE
Connected to @ISCSIADM_ABSTRACT_NAMESPACE
$ sudo systemctl status --full --no-pager iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; disabled; vendor preset: enabled)
Active: active (running) since Mon 2018-10-01 21:20:49 UTC; 14s ago
Docs: man:iscsid(8)
Process: 1013 ExecStart=/sbin/iscsid (code=exited, status=0/SUCCESS)
Process: 1001 ExecStartPre=/lib/open-iscsi/startup-checks.sh (code=exited, status=0/SUCCESS)
Main PID: 1015 (iscsid)
Tasks: 2 (limit: 2361)
CGroup: /system.slice/iscsid.service
├─1014 /sbin/iscsid
└─1015 /sbin/iscsid
Oct 01 21:20:49 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator daemon (iscsid)...
Oct 01 21:20:49 bionic-20181001-195627 iscsid[1013]: iSCSI logger with pid=1014 started!
Oct 01 21:20:49 bionic-20181001-195627 systemd[1]: iscsid.service: Failed to parse PID from file /run/iscsid.pid: Invalid argument
Oct 01 21:20:49 bionic-20181001-195627 iscsid[1014]: iSCSI daemon with pid=1015 started!
Oct 01 21:20:49 bionic-20181001-195627 systemd[1]: Started iSCSI initiator daemon (iscsid).
● iscsid.socket - Open-iSCSI iscsid Socket
Loaded: loaded (/lib/systemd/system/iscsid.socket; enabled; vendor preset: enabled)
Active: active (running) since Mon 2018-10-01 21:20:19 UTC; 44s ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream)
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 01 21:20:19 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Mon 2018-10-01 21:20:19 UTC; 44s ago
├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met
└─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met
Docs: man:iscsiadm(8)
man:iscsid(8)
### 2. upgrade install, should have service (still) on, socket enabled.
$ sudo apt-get --purge remove open-iscs
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package open-iscs
$ sudo apt-get --purge remove open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
open-iscsi*
0 upgraded, 0 newly installed, 1 to remove and 51 not upgraded.
After this operation, 1417 kB disk space will be freed.
Do you want to continue? [Y/n]
(Reading database ... 59667 files and directories currently installed.)
Removing open-iscsi (2.0.874-5ubuntu2.2) ...
Warning: Stopping iscsid.service, but it can still be activated by:
iscsid.socket
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Processing triggers for man-db (2.8.3-2) ...
(Reading database ... 59632 files and directories currently installed.)
Purging configuration files for open-iscsi (2.0.874-5ubuntu2.2) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for systemd (237-3ubuntu10.3) ...
$ sudo apt-get install open-iscsi=2.0.874-5ubuntu2.1
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
open-iscsi
0 upgraded, 1 newly installed, 0 to remove and 51 not upgraded.
Need to get 280 kB of archives.
After this operation, 1413 kB of additional disk space will be used.
Get:1 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-updates/main amd64 open-iscsi amd64 2.0.874-5ubuntu2.1 [280 kB]
Fetched 280 kB in 0s (708 kB/s)
Preconfiguring packages ...
Selecting previously unselected package open-iscsi.
(Reading database ... 59627 files and directories currently installed.)
Preparing to unpack .../open-iscsi_2.0.874-5ubuntu2.1_amd64.deb ...
Unpacking open-iscsi (2.0.874-5ubuntu2.1) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
cp: cannot stat '/etc/iscsi/initiatorname.iscsi': No such file or directory
Setting up open-iscsi (2.0.874-5ubuntu2.1) ...
Created symlink /etc/systemd/system/sysinit.target.wants/iscsid.service → /lib/systemd/system/iscsid.service.
Created symlink /etc/systemd/system/iscsi.service → /lib/systemd/system/open-iscsi.service.
Created symlink /etc/systemd/system/sysinit.target.wants/open-iscsi.service → /lib/systemd/system/open-iscsi.service.
Processing triggers for systemd (237-3ubuntu10.3) ...
Processing triggers for man-db (2.8.3-2) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Processing triggers for ureadahead (0.100.0-20) ...
$ sudo systemctl status --full --no-pager iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; enabled; vendor preset: enabled)
Active: active (running) since Tue 2018-10-02 00:20:23 UTC; 20s ago
Docs: man:iscsid(8)
Main PID: 9942 (iscsid)
Tasks: 2 (limit: 2361)
CGroup: /system.slice/iscsid.service
├─9941 /sbin/iscsid
└─9942 /sbin/iscsid
Oct 02 00:20:22 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator daemon (iscsid)...
Oct 02 00:20:23 bionic-20181001-195627 iscsid[9933]: iSCSI logger with pid=9941 started!
Oct 02 00:20:23 bionic-20181001-195627 systemd[1]: iscsid.service: Failed to parse PID from file /run/iscsid.pid: Invalid argument
Oct 02 00:20:23 bionic-20181001-195627 iscsid[9941]: iSCSI daemon with pid=9942 started!
Oct 02 00:20:23 bionic-20181001-195627 systemd[1]: Started iSCSI initiator daemon (iscsid).
● iscsid.socket
Loaded: not-found (Reason: No such file or directory)
Active: active (listening) since Mon 2018-10-01 21:20:19 UTC; 3h 0min ago
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 01 21:20:19 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Tue 2018-10-02 00:20:23 UTC; 20s ago
Docs: man:iscsiadm(8)
man:iscsid(8)
## now upgrade
$ sudo apt-get install open-iscsi
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be upgraded:
open-iscsi
1 upgraded, 0 newly installed, 0 to remove and 51 not upgraded.
Need to get 0 B/280 kB of archives.
After this operation, 4096 B of additional disk space will be used.
Preconfiguring packages ...
(Reading database ... 59666 files and directories currently installed.)
Preparing to unpack .../open-iscsi_2.0.874-5ubuntu2.2_amd64.deb ...
Unpacking open-iscsi (2.0.874-5ubuntu2.2) over (2.0.874-5ubuntu2.1) ...
Processing triggers for ureadahead (0.100.0-20) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
Setting up open-iscsi (2.0.874-5ubuntu2.2) ...
Installing new version of config file /etc/iscsi/iscsid.conf ...
Created symlink /etc/systemd/system/sockets.target.wants/iscsid.socket → /lib/systemd/system/iscsid.socket.
Processing triggers for systemd (237-3ubuntu10.3) ...
Processing triggers for man-db (2.8.3-2) ...
Processing triggers for initramfs-tools (0.130ubuntu3.3) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-34-generic
$ sudo systemctl status --full --no-pager iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; disabled; vendor preset: enabled)
Active: active (running) since Tue 2018-10-02 00:21:20 UTC; 18s ago
Docs: man:iscsid(8)
Main PID: 18493 (iscsid)
Tasks: 2 (limit: 2361)
CGroup: /system.slice/iscsid.service
├─18492 /sbin/iscsid
└─18493 /sbin/iscsid
Oct 02 00:21:20 bionic-20181001-195627 systemd[1]: Stopped iSCSI initiator daemon (iscsid).
Oct 02 00:21:20 bionic-20181001-195627 systemd[1]: Starting iSCSI initiator daemon (iscsid)...
Oct 02 00:21:20 bionic-20181001-195627 systemd[1]: iscsid.service: Failed to parse PID from file /run/iscsid.pid: Invalid argument
Oct 02 00:21:20 bionic-20181001-195627 iscsid[18492]: iSCSI daemon with pid=18493 started!
Oct 02 00:21:20 bionic-20181001-195627 systemd[1]: Started iSCSI initiator daemon (iscsid).
● iscsid.socket - Open-iSCSI iscsid Socket
Loaded: loaded (/lib/systemd/system/iscsid.socket; enabled; vendor preset: enabled)
Active: active (running) since Mon 2018-10-01 21:20:19 UTC; 3h 1min ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream)
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 01 21:20:19 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Tue 2018-10-02 00:21:20 UTC; 18s ago
Docs: man:iscsiadm(8)
man:iscsid(8)
### 3. after 2. reboot should be service off socket on
$ reboot
$ ...
$ sudo systemctl status --full --no-pager iscsid.service iscsid.socket open-iscsi.service
● iscsid.service - iSCSI initiator daemon (iscsid)
Loaded: loaded (/lib/systemd/system/iscsid.service; disabled; vendor preset: enabled)
Active: inactive (dead)
Docs: man:iscsid(8)
● iscsid.socket - Open-iSCSI iscsid Socket
Loaded: loaded (/lib/systemd/system/iscsid.socket; enabled; vendor preset: enabled)
Active: active (listening) since Tue 2018-10-02 00:22:33 UTC; 37s ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Listen: @ISCSIADM_ABSTRACT_NAMESPACE (Stream)
CGroup: /system.slice/iscsid.socket
Failed to dump process list, ignoring: No such file or directory
Oct 02 00:22:33 bionic-20181001-195627 systemd[1]: Listening on Open-
iSCSI iscsid Socket.
● open-iscsi.service - Login to default iSCSI targets
Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled)
Active: inactive (dead)
Condition: start condition failed at Tue 2018-10-02 00:22:33 UTC; 37s ago
├─ ConditionDirectoryNotEmpty=|/etc/iscsi/nodes was not met
└─ ConditionDirectoryNotEmpty=|/sys/class/iscsi_session was not met
Docs: man:iscsiadm(8)
man:iscsid(8)
** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1755858
Title:
iscsid autostarts on all servers when it has nothing to do
Status in open-iscsi package in Ubuntu:
Fix Released
Status in open-iscsi source package in Xenial:
New
Status in open-iscsi source package in Bionic:
Fix Committed
Status in open-iscsi package in Debian:
New
Bug description:
[Impact]
* Service is running uselessly which is consuming a few cycles/memory as
well as raising general concerns e.g. on minimizing attack surface of
a system.
* This is also the only service in a default server install which
pulls in the network-online.target, which has implications for boot
ordering and speed in various configurations.
* Fix by switching to socket activation
[Test Case]
* After installing open-iscsi (which is default installed) the service
iscsid is running which is mostly useless
- this is a bit critical, as we don't want to stop a running service.
- so you have two cases
1. uninstall the package before upgrade; then install the new version.
should be service off, socket on
2. upgrade install, should have service (still) on, socket enabled.
3. after 2. reboot should be service off, socket on
* Also ensure that iscsid.service should come up as needed
# should be off
$ systemctl status iscsid.service iscsid.socket
$ iscsiadm -m discovery -t sendtargets -p 127.0.0.1
# should be enabled now
$ systemctl status iscsid.service iscsid.socket
[Regression Potential]
* We were discussing if we shall SRU this. First of all the change should
work as in the new version, abstract sockets are not super new.
* We were concerned that one would have e.g. scripts and other upper
level code that does like:
if service-is-not-running; then break; else do what you should do
This would give up before socket-triggering it which might be too much
to SRU. On a Upgrade to a newer release such minor adaptions are usual,
but for SRUs?
But in any config using it it will run, and as slangasek outlined " I
think anyone checking for the running status of an open-iscsi service,
on a system that does not have any iscsi targets configured, is writing
buggy code and that should not be catered to in the face of the
significant impact this bug has on all other users of Ubuntu Server."
* But also we don't stop the service on upgrade (for safety of the data),
so you'd have four different Bionics
a) old iscsid.service runnign by default
b) upgraded, but not rebooted iscsid.service still running
c) upgraded, rebooted iscid.service disabled,
iscsid.socket running
d) new deploy after this (e.g. new cloud image) iscid.service disabled,
iscsid.socket running
a+b are similar as well as c+d.
* If anyone strictly needs the old behavior it is a config, so one can
"systemctl enable iscsid.service" and is done.
* OTOH in our discussion it was agreed that the upgrade regression we fix
outweighs the potential regression.
[Other Info]
* n/a
---
In bionic, the open-iscsi systemd unit has the following guards to
keep it from running on systems with no iscsi targets configured:
# Must have some pre-defined targets to login to
ConditionDirectoryNotEmpty=|/etc/iscsi/nodes
# or have a session to use via iscsid
ConditionDirectoryNotEmpty=|/sys/class/iscsi_session
However, iscsid starts from a separate unit and does not include this
check. Thus, iscsid starts on every Ubuntu Server install, whether or
not it has anything to do.
We should replicate these unit conditionals to the iscsid unit, to
ensure the daemon doesn't run (consuming memory, and slowing boot)
when not needed.
Related bugs:
* bug 1630946: ubuntu-server depends on open-iscsi and runs iscsid
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions
More information about the foundations-bugs
mailing list