[Bug 1794936] Re: new gccgo version update (4:8.2.0-1ubuntu2.1) is triggering dh-golang <1.35 bug

[Michael Hudson-Doyle]

That worked better:

root at bionic:~# apt source golang-petname
Reading package lists... Done
NOTICE: 'golang-petname' packaging is maintained in the 'Bzr' version control system at:
https://code.launchpad.net/petname/petname/trunk
Please use:
bzr branch https://code.launchpad.net/petname/petname/trunk
to retrieve the latest (possibly unreleased) updates to the package.
Need to get 20.9 kB of source archives.
Get:1 http://archive.ubuntu.com/ubuntu bionic/universe golang-petname 2.8-0ubuntu2 (dsc) [2113 B]
Get:2 http://archive.ubuntu.com/ubuntu bionic/universe golang-petname 2.8-0ubuntu2 (tar) [13.6 kB]
Get:3 http://archive.ubuntu.com/ubuntu bionic/universe golang-petname 2.8-0ubuntu2 (diff) [5148 B]
Fetched 20.9 kB in 1s (32.1 kB/s)   
dpkg-source: info: extracting golang-petname in golang-petname-2.8
dpkg-source: info: unpacking golang-petname_2.8.orig.tar.gz
dpkg-source: info: unpacking golang-petname_2.8-0ubuntu2.debian.tar.xz
W: Download is performed unsandboxed as root as file 'golang-petname_2.8-0ubuntu2.dsc' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
root at bionic:~# cd golang-petname-*/
root at bionic:~/golang-petname-2.8# sed -i -e 's/golang-go/gccgo-go/' debian/control
root at bionic:~/golang-petname-2.8# apt build-dep ./
Note, using directory './' to get the build dependencies
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following packages were automatically installed and are no longer required:
  golang-1.10-go golang-1.10-src golang-src libfreetype6
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 23 not upgraded.
root at bionic:~/golang-petname-2.8# dpkg-buildpackage
dpkg-buildpackage: info: source package golang-petname
dpkg-buildpackage: info: source version 2.8-0ubuntu2
[...]
 dpkg-genbuildinfo
 dpkg-genchanges  >../golang-petname_2.8-0ubuntu2_amd64.changes
dpkg-genchanges: info: not including original source code in upload
 dpkg-source --after-build golang-petname-2.8
dpkg-buildpackage: info: binary and diff upload (original source NOT included)
root at bionic:~/golang-petname-2.8# dpkg -l dh-golang
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                         Version             Architecture        Description
+++-============================-===================-===================-==============================================================
ii  dh-golang                    1.34.2              all                 debhelper add-on for packaging software written in Go (golang)


** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to dh-golang in Ubuntu.
https://bugs.launchpad.net/bugs/1794936

Title:
  new gccgo version update (4:8.2.0-1ubuntu2.1)  is triggering dh-golang
  <1.35 bug

Status in dh-golang package in Ubuntu:
  Fix Released
Status in gcc-8 package in Ubuntu:
  Invalid
Status in dh-golang source package in Bionic:
  Fix Committed
Status in gcc-8 source package in Bionic:
  New

Bug description:
  [impact]
  Packages that use gccgo-go to build fail to build. There aren't really any such packages in Ubuntu today, but it's still a broken situation.

  [test case]
  $ apt source golang-petname
  $ cd golang-petname-*/
  $ sed -i -e 's/golang-go/gccgo-go/' debian/control
  $ apt build-dep ./
  $ dpkg-buildpackage

  [regression potential]
  The added patch adds code that only runs if 'go version' contains gccgo, which means that it only affects builds where the default go is gccgo-go, i.e. the builds that are currently broken by this bug. It will not affect any other build.

  [original description]
  We see this kind of error in recent runs of snapd tests when using bionic updating gccgo 4:8.2.0-1ubuntu2.1 and current dh-golang 1.34.

  Can be run  from snapd master checkout with:

  spread -v -debug google:ubuntu-18.04-64:tests/unit/gccgo

  with the proper configuration.

  Error:

  ...
    dh_makeshlibs -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
     dh_shlibdeps -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
     debian/rules override_dh_installdeb
  make[1]: Entering directory '/home/gopath/src/github.com/snapcore/snapd'
  dh_apparmor --profile-name=usr.lib.snapd.snap-confine.real -psnapd
  dh_installdeb
  make[1]: Leaving directory '/home/gopath/src/github.com/snapcore/snapd'
     dh_golang -O--buildsystem=golang -O--fail-missing -O--builddirectory=_build
  template: main:2:14: executing "main" at <index (or .GoFiles ....>: error calling index: index out of range: 0
  dh_golang: go list -f '\
  {{ .Dir }}/{{ index (or .GoFiles .CgoFiles .TestGoFiles .XTestGoFiles .IgnoredGoFiles) 0 }}' returned exit code 1
  debian/rules:103: recipe for target 'binary' failed
  make: *** [binary] Error 1
  dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
  -----

  These were passing until today.

  Seems related/similar to https://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=907263

  which mentions dh-golang 1.35 having a fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dh-golang/+bug/1794936/+subscriptions