[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

[Brian Murray]

Hello Rolando, or anyone else affected,

Accepted samba into bionic-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/samba/2:4.7.6+dfsg
~ubuntu-0ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: samba (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to samba in Ubuntu.
https://bugs.launchpad.net/bugs/1795772

Title:
  rmdir on non-empty samba directory fails silently

Status in samba:
  Unknown
Status in samba package in Ubuntu:
  Fix Released
Status in samba source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

  The samba client doesn't check the result of rmdir, returning success
  when the directory is not empty. This results in clients reporting
  successful directory removal when in fact the directory was not
  removed.

  This bug affects anything that uses the samba client, including file
  managers, mount, and gvfs.

  [Test Case]

  # lxc launch ubuntu-daily:cosmic sambatest
  # lxc exec sambatest bash

  Inside container:

  # apt update
  # apt dist-upgrade -y
  # apt install -y samba samba-client
  # mkdir -p /tmp/shared/testdir/testsubdir
  # chown -R nobody:nogroup /tmp/shared
  # printf "%s" "[global]
      workgroup = WORKGROUP
      server role = standalone server
      security = user
      map to guest = Bad User
      guest ok = yes
      guest only = yes
      guest account = nobody
  [shared]
      path = /tmp/shared
      writable = yes
      browsable = yes
      guest ok = yes
  " | tee "/etc/samba/smb.conf" >/dev/null
  # service smbd restart

  # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF
  rmdir testdir
  quit
  EOF

  * Should get NT_STATUS_DIRECTORY_NOT_EMPTY

  [Upstream Report and Fix]

  https://bugzilla.samba.org/show_bug.cgi?id=13204

  https://attachments.samba.org/attachment.cgi?id=14408

  [Regression Potential]

  If the fix is implemented incorrectly, clients may receive false error
  messages, and report failure even on success when removing
  directories.

  [Original Description]

  When you delete a non-empty directory in Nautilus or Nemo, the Folder-
  Icon disappears and stays away but when you refresh the current
  directory or navigate back there it reappears. No error message at
  all. This bug is very annoying in two ways:

  1) When you only have smb access to the share you have to delete all
  files and directories in sub, subsub and subsubsubdirecories by hand
  to actually delete a directory.

  2) You don't get warned that the delete operation failed. In our case
  this produced a horrible mess in our shares before we recognized what
  was going wrong.

  You can find many people complaining in various forums. I found bug
  reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems
  to be this (upstream fixed) bug in samba:

  https://bugzilla.samba.org/show_bug.cgi?id=13204

  Please cherry pick the fix into current version of samba.

  Thanks a lot for your help!

To manage notifications about this bug go to:
https://bugs.launchpad.net/samba/+bug/1795772/+subscriptions