[Bug 1799839] Re: not possible to use "Repair broken packages"

[Brian Murray]

I installed the version of ubuntu-release-upgrader from -proposed on an
Ubuntu 18.10 system then rebooted into recovery mode and was able to
successfully launch "repair broken packages".

** Attachment added: "Screenshot from 2018-11-05 09-25-27.png"
   https://bugs.launchpad.net/ubuntu/+source/friendly-recovery/+bug/1799839/+attachment/5209408/+files/Screenshot%20from%202018-11-05%2009-25-27.png

** Tags removed: verification-needed-cosmic
** Tags added: verification-done-cosmic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to friendly-recovery in Ubuntu.
https://bugs.launchpad.net/bugs/1799839

Title:
  not possible to use "Repair broken packages"

Status in friendly-recovery package in Ubuntu:
  Triaged
Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in friendly-recovery source package in Bionic:
  New
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in friendly-recovery source package in Cosmic:
  New
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  It is not possible to use "Repair broken packages" in friendly recovery as it calls dist-upgrade.py and that fails as it checks to see if the python symlink, not python3 symlink is good.

  [Test Case]
  Run the following as root:

  env RELEASE_UPGRADER_NO_SCREEN=1 python3 "/usr/lib/python3/dist-
  packages/DistUpgrade/dist-upgrade.py" --partial --frontend
  DistUpgradeViewText --datadir /usr/share/ubuntu-release-upgrader

  With the version in the archive you'll receive an error regarding your
  python install being corrupted, with the version from --proposed you
  won't.

  Also after installing the new version of python3-distupgrade the
  system should be booted into recovery mode and it confirmed that the
  "Repair broken packages" menu item works.

  [Regression Potential]
  The code is just being updated to use python3 instead of python so there isn't any change of a regression.

  The menu item "Repair broken packages" calls the following command:

  env RELEASE_UPGRADER_NO_SCREEN=1 python3 "/usr/lib/python3/dist-
  packages/DistUpgrade/dist-upgrade.py" --partial --frontend
  DistUpgradeViewText --datadir /usr/share/ubuntu-release-upgrader

  However, that fails with the following:

  Your python install is corrupted. Please fix the '/usr/bin/python'
  symlink.

  This is because of the _pythonSymlinkCheck function in
  DistUpgradeController.py (provided by ubuntu-release-upgrader) using
  os.readlink('/usr/bin/python') but not os.readlink() on what the first
  os.readlink() call returned. That being said the whole function should
  be updated to see if python3 is being used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/friendly-recovery/+bug/1799839/+subscriptions