[Bug 1781128] Re: Valgrind utility is missing bug fixes since 3.13.0 release

[Dimitri John Ledkov]

I did retest of the xvnegsp test case.
It's broken in bionic, bionic-proposed, cosmic, and disco.
Disco-proposed has updated valgrind, but it FTBFS.

So to answer robbies question - no, this SRU was never meant to fix the
second testcase as that is still broken everywhere. But this SRU did
meant to, and has fixed the first and third testcase.

I think from here we should release bionic SRU; work on upgrading
valgrind in disco; and then cherrypick the above identified things into
cosmic/bionic to fixup valgrinding xvnegsp instruction.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to valgrind in Ubuntu.
https://bugs.launchpad.net/bugs/1781128

Title:
  Valgrind utility is missing bug fixes since 3.13.0 release

Status in The Ubuntu-power-systems project:
  Fix Committed
Status in valgrind package in Ubuntu:
  Fix Released
Status in valgrind source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

   * Valgrind is unable to execute certain binaries, or executes them
  incorrectly on ppc64el platform in bionic.

  [Test Case]

   * Compile the following test cases, they should execute correctly
  normally and under valgrind; without illegal opcodes and returning the
  same output lengths for timebase.

  int main()
  {
  asm ("mtspr 3,0");
  }

  int main()
  {
  asm ("xvnegsp 33,34");
  }

  #include <stdio.h>
  #include <sys/platform/ppc.h>

  int main(int argc, char** argv)
  {
  uint64_t tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);
  sleep(15);
  tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);

  return 0;
  }

  
  [Regression Potential] 

   * These are upstream included and tested patches, cherrypicked into
  bionic, affect power code-paths only, and tested/released in cosmic.

  [Other Info]
   
   * Original bug report.

  ---Problem Description---
  Valgrind is missing the PPC64 bug fixes and fixes for missing support since the Valgrind 3.13.0 release in June of 2017.  This is causing users trying to use Valgrind to get internal Valgrind errors.  This bugzilla is to get the latest PPC64 patches added to the Ubuntu 18.04 release.

  ---uname output---
  Linux genoa 4.4.0-130-generic #156-Ubuntu

  Machine Type = Power 9

  ---Steps to Reproduce---
   Valgrind ./user_application
  Where the user_application includes vpermr instructions

  Need to have this bugzilla mirred to the Ubuntu Launchpad so we can
  get the right people from Ubuntu to discuss how to address getting the
  needed updates into the long term release support for 18.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1781128/+subscriptions