[Bug 1781128] Comment bridged from LTC Bugzilla

[bugproxy]

------- Comment From willschm at us.ibm.com 2018-11-01 09:52 EDT-------
(In reply to comment #15)
> I expect /bin/true to use to heap. As it should be effectively `int
> main(){return 0;}`.
> Valgrind in general does work, with heap allocating apps.
>
> I'm not sure yet what's up with xvnegsp. As i don't see anything explicit to
> either fix it, or break it, or otherwise missing to support it.

Looking through the tarball that was provided via this bugzilla, it
looks to me like the xvnegsp fix was not included.

The functional fix for xvnegsp would need to be pulled in.  this is upstream commit:
commit 9c5d762904862db0d90fb0142ac1b12d5647f607
Author: Carl Love <carll at us.ibm.com>
Date:   Thu Jun 21 17:27:40 2018 -0500
PPC64, add support for the xvnegsp instruction. Add test case for the instruction.

Also recommend the testcase output checking changes, which is upstream commit:
commit 1f69ed86e994ee152a0e6e3ee7031d0105f02a7e
Author: Carl Love <carll at us.ibm.com>
Date:   Mon Jun 25 16:24:14 2018 -0500
Fix ppc32 results for test_isa_2_06_part3.c.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to valgrind in Ubuntu.
https://bugs.launchpad.net/bugs/1781128

Title:
  Valgrind utility is missing bug fixes since 3.13.0 release

Status in The Ubuntu-power-systems project:
  Fix Committed
Status in valgrind package in Ubuntu:
  Fix Released
Status in valgrind source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

   * Valgrind is unable to execute certain binaries, or executes them
  incorrectly on ppc64el platform in bionic.

  [Test Case]

   * Compile the following test cases, they should execute correctly
  normally and under valgrind; without illegal opcodes and returning the
  same output lengths for timebase.

  int main()
  {
  asm ("mtspr 3,0");
  }

  int main()
  {
  asm ("xvnegsp 33,34");
  }

  #include <stdio.h>
  #include <sys/platform/ppc.h>

  int main(int argc, char** argv)
  {
  uint64_t tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);
  sleep(15);
  tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);

  return 0;
  }

  
  [Regression Potential] 

   * These are upstream included and tested patches, cherrypicked into
  bionic, affect power code-paths only, and tested/released in cosmic.

  [Other Info]
   
   * Original bug report.

  ---Problem Description---
  Valgrind is missing the PPC64 bug fixes and fixes for missing support since the Valgrind 3.13.0 release in June of 2017.  This is causing users trying to use Valgrind to get internal Valgrind errors.  This bugzilla is to get the latest PPC64 patches added to the Ubuntu 18.04 release.

  ---uname output---
  Linux genoa 4.4.0-130-generic #156-Ubuntu

  Machine Type = Power 9

  ---Steps to Reproduce---
   Valgrind ./user_application
  Where the user_application includes vpermr instructions

  Need to have this bugzilla mirred to the Ubuntu Launchpad so we can
  get the right people from Ubuntu to discuss how to address getting the
  needed updates into the long term release support for 18.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1781128/+subscriptions