[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

[Steve Langasek]

On Wed, May 23, 2018 at 01:58:05PM -0000,  Christian Ehrhardt  wrote:
> Fortunately we are so early in the cycle that I'd say if reviews and
> tests seem good we can change it. And if on any image/maas/cloud tests
> we break things we didn't expect there is time enough to revert it
> before cosmic is entering any Freeze.

I think we should be concerned about SRUing this change to bionic as well. 
iscsid.service declares Wants=network-online.target, which slows down the
boot in cases where the system for whatever reason can't confirm right away
that the network is up.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1755858

Title:
  iscsid autostarts on all servers when it has nothing to do

Status in open-iscsi package in Ubuntu:
  Triaged
Status in open-iscsi source package in Bionic:
  Triaged

Bug description:
  In bionic, the open-iscsi systemd unit has the following guards to
  keep it from running on systems with no iscsi targets configured:

  # Must have some pre-defined targets to login to
  ConditionDirectoryNotEmpty=|/etc/iscsi/nodes
  # or have a session to use via iscsid
  ConditionDirectoryNotEmpty=|/sys/class/iscsi_session

  However, iscsid starts from a separate unit and does not include this
  check.  Thus, iscsid starts on every Ubuntu Server install, whether or
  not it has anything to do.

  We should replicate these unit conditionals to the iscsid unit, to
  ensure the daemon doesn't run (consuming memory, and slowing boot)
  when not needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions