[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

[ Christian Ehrhardt ]

I have a test branch and build
+  * make iscsid socket activated to only activate it as-needed (LP: #1755858)
+    - debian/open-iscsi.socket: systemd socket file for iscsid
+    - debian/open-iscsi.service: do not start or check iscsid.service
+    - debian/rules: install and enable iscsid.socket
+    - debian/patches/iscid-conf-use-systemd.socket-patch: default to the socket

Building in ppa [1] now.
It is not yet up for final review, but feel free to take a look at [2]

I Won't have time for it anymore for a bit, some tests on the ppa
(upgrades and how they affect it as well as new installs - since it is
there by default the latter meant purge+ppa+install).

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3268 for further tests.
[2]: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1755858

Title:
  iscsid autostarts on all servers when it has nothing to do

Status in open-iscsi package in Ubuntu:
  Triaged
Status in open-iscsi source package in Bionic:
  Triaged

Bug description:
  In bionic, the open-iscsi systemd unit has the following guards to
  keep it from running on systems with no iscsi targets configured:

  # Must have some pre-defined targets to login to
  ConditionDirectoryNotEmpty=|/etc/iscsi/nodes
  # or have a session to use via iscsid
  ConditionDirectoryNotEmpty=|/sys/class/iscsi_session

  However, iscsid starts from a separate unit and does not include this
  check.  Thus, iscsid starts on every Ubuntu Server install, whether or
  not it has anything to do.

  We should replicate these unit conditionals to the iscsid unit, to
  ensure the daemon doesn't run (consuming memory, and slowing boot)
  when not needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858/+subscriptions