[Bug 1776815] [NEW] parseSignArgs call fails on sucess

[Peter Howe]

Public bug reported:

for version 4.14.1+dfsg1-2.dpkg  affects python3-rpm

in python/rpmsmodule.c the two calls to parseSignArgs in addSign and
delSign should be inverted:

--- rpm-4.14.1+dfsg1.orig/python/rpmsmodule.c
+++ rpm-4.14.1+dfsg1/python/rpmsmodule.c
@@ -20,7 +20,7 @@ static PyObject * addSign(PyObject * sel
     const char *path = NULL;
     struct rpmSignArgs sargs;
 
-    if (parseSignArgs(args, kwds, &path, &sargs))
+    if (!parseSignArgs(args, kwds, &path, &sargs))
     return NULL;
 
     return PyBool_FromLong(rpmPkgSign(path, &sargs) == 0);
@@ -31,7 +31,7 @@ static PyObject * delSign(PyObject * sel
     const char *path = NULL;
     struct rpmSignArgs sargs;
 
-    if (parseSignArgs(args, kwds, &path, &sargs))
+    if (!parseSignArgs(args, kwds, &path, &sargs))
     return NULL;
 
     return PyBool_FromLong(rpmPkgDelSign(path, &sargs) == 0);

This is fixed in newer upstream, but not in 4.14.1.

** Affects: rpm (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rpm in Ubuntu.
https://bugs.launchpad.net/bugs/1776815

Title:
  parseSignArgs call fails on sucess

Status in rpm package in Ubuntu:
  New

Bug description:
  for version 4.14.1+dfsg1-2.dpkg  affects python3-rpm

  in python/rpmsmodule.c the two calls to parseSignArgs in addSign and
  delSign should be inverted:

  --- rpm-4.14.1+dfsg1.orig/python/rpmsmodule.c
  +++ rpm-4.14.1+dfsg1/python/rpmsmodule.c
  @@ -20,7 +20,7 @@ static PyObject * addSign(PyObject * sel
       const char *path = NULL;
       struct rpmSignArgs sargs;
   
  -    if (parseSignArgs(args, kwds, &path, &sargs))
  +    if (!parseSignArgs(args, kwds, &path, &sargs))
       return NULL;
   
       return PyBool_FromLong(rpmPkgSign(path, &sargs) == 0);
  @@ -31,7 +31,7 @@ static PyObject * delSign(PyObject * sel
       const char *path = NULL;
       struct rpmSignArgs sargs;
   
  -    if (parseSignArgs(args, kwds, &path, &sargs))
  +    if (!parseSignArgs(args, kwds, &path, &sargs))
       return NULL;
   
       return PyBool_FromLong(rpmPkgDelSign(path, &sargs) == 0);

  This is fixed in newer upstream, but not in 4.14.1.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rpm/+bug/1776815/+subscriptions