[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

[Brian Murray]

I've verified the test case for an upgrade from Bionic to Cosmic.

bdmurray at clean-bionic-amd64:~$ grep vte /var/log/dist-upgrade/apt-term.log 
Preparing to unpack .../143-libvte-2.91-common_0.52.2-1ubuntu1_all.deb ...
Unpacking libvte-2.91-common (0.52.2-1ubuntu1) over (0.52.2-1ubuntu1~18.04.2) ...
Preparing to unpack .../144-libvte-2.91-0_0.52.2-1ubuntu1_amd64.deb ...
Unpacking libvte-2.91-0:amd64 (0.52.2-1ubuntu1) over (0.52.2-1ubuntu1~18.04.2) ...
Preparing to unpack .../145-gir1.2-vte-2.91_0.52.2-1ubuntu1_amd64.deb ...
Unpacking gir1.2-vte-2.91:amd64 (0.52.2-1ubuntu1) over (0.52.2-1ubuntu1~18.04.2) ...
Setting up libvte-2.91-common (0.52.2-1ubuntu1) ...
Setting up libvte-2.91-0:amd64 (0.52.2-1ubuntu1) ...
Setting up gir1.2-vte-2.91:amd64 (0.52.2-1ubuntu1) ...

bdmurray at clean-bionic-amd64:~$ grep -C5 "/etc/issue" /var/log/dist-upgrade/apt-term.log 
Warning: Stopping motd-news.service, but it can still be activated by:
  motd-news.timer
Unpacking base-files (10.1ubuntu4) over (10.1ubuntu2) ...
Setting up base-files (10.1ubuntu4) ...

Configuration file '/etc/issue'
 ==> Modified (by you or by a script) since installation.
 ==> Package distributor has shipped an updated version.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** issue (Y/I/N/O/D/Z) [default=N] ? y
Installing new version of config file /etc/issue ...

However, given the potential for a regression some additional testing
should be done.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1780501

Title:
  Traceback calling Vte.Terminal.feed_child()

Status in ubuntu-release-upgrader package in Ubuntu:
  Triaged
Status in vte2.91 package in Ubuntu:
  Won't Fix
Status in ubuntu-release-upgrader source package in Bionic:
  Invalid
Status in vte2.91 source package in Bionic:
  Fix Committed

Bug description:
  [Test Case]
  1) Ensure the following packages from -updates (version 0.52.2-1ubuntu1~18.04.1) are installed on an Ubuntu 18.04 system: gir1.2-vte-2.91 libvte-2.91-0 libvte-2.91-common
  2) Modify /etc/issue e.g. I changed 18.04 to 18.04.2
  3) Ensure /etc/update-manager/release-upgrades contains "Prompt=normal"
  4) Run /usr/lib/ubuntu-release-upgrader/check-new-release-gtk -d
  5) When prompted about replacing "the customized configuration file '/etc/issue'" click Keep
  6) Observe a traceback in Vte.Terminal.feed_child()

  After installing the new version of vte2.91 in -proposed you should no
  longer receive a Traceback when clicking keep during the upgrade
  process.

  [Regression Potential]
  Per laney: "The regression potential is that I messed up the upload and everything using feed* breaks."

  It'd probably be good to test guake too since it uses feed_child().

  [Original Description]
  I was upgrading from Bionic to Cosmic when I received a conffile prompt regarding /etc/update-initramfs/initramfs.conf, I clicked keep and then saw this Traceback:

  Original exception was:
  Traceback (most recent call last):
    File "/tmp/ubuntu-release-upgrader-filpk342/cosmic", line 8, in <module>
      sys.exit(main())
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeMain.py", line 238, in main
      if app.run():
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeController.py", line 1949, in run
      return self.fullUpgrade()
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeController.py", line 1912, in fullUpgrade
      if not self.doDistUpgrade():
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeController.py", line 1248, in doDistUpgrade
      res = self.cache.commit(fprogress,iprogress)
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeCache.py", line 293, in commit
      apt.Cache.commit(self, fprogress, iprogress)
    File "/usr/lib/python3/dist-packages/apt/cache.py", line 606, in commit
      pm = apt_pkg.PackageManager(self._depcache)
    File "/usr/lib/python3/dist-packages/apt/cache.py", line 569, in install_archives
      # compat with older API
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeView.py", line 229, in run
      res = os.WEXITSTATUS(self.wait_child())
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeViewGtk3.py", line 340, in wait_child
      self.update_interface()
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeViewGtk3.py", line 347, in update_interface
      InstallProgress.update_interface(self)
    File "/usr/lib/python3/dist-packages/apt/progress/base.py", line 252, in update_interface
      if err.errno != errno.EAGAIN and err.errno != errno.EWOULDBLOCK:
    File "/tmp/ubuntu-release-upgrader-filpk342/DistUpgrade/DistUpgradeViewGtk3.py", line 276, in conffile
      self.term.feed_child("n\n", -1)
  TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1780501/+subscriptions