[Bug 1771845] Re: grub-installer raid handling code missing nvme from sed filter

[Dimitri John Ledkov]

Using 18.04.0 installer, and trying to install into mdadm device, guided
installation, fails in BIOS mode, whne mdadm device consists of two nvme
partition devices e.g. /dev/nvme1n1p1 /dev/nvme0n1p1.

Using the latest bionic-server daily, with the grub-installer
1.128ubuntu8.18.04.2 install works and boots fine.

I was not able to succeed installing similar setup using UEFI and Linux
raid, which is somewhat expected, as that's not supported (i.e. to have
ESP on top of linux raid).

The BIOS-only reproducer, and validation of the fix, is sufficient to
validate this SRU.

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub-installer in Ubuntu.
https://bugs.launchpad.net/bugs/1771845

Title:
  grub-installer raid handling code missing nvme from sed filter

Status in grub-installer package in Ubuntu:
  Fix Released
Status in grub-installer source package in Bionic:
  Fix Committed
Status in grub-installer source package in Cosmic:
  Fix Released

Bug description:
  [Impact]
  Installs on NVMe hardware, on RAID deployments (RAID made of NVMe devices).

  [Test case]
  - Install Ubuntu on NVMe drives, configure the drives in RAID.

  [Regression potential]
  Attention should be taken to the behavior of installs, especially on RAID arrays: given the changes to the device matching, failure to recognize some devices that should be part of the RAID array, or to see devices outside of the RAID array when they were not added to the array, should be investigated as potential regressions coming from this change.

  --

  It appears that Ubuntu patched grub-installer to handle raid arrays,
  duplicating some sed filters from earlier parts of the code.  Debian
  probably added nvme to the earlier parts but the duplicate in the
  Ubuntu specific raid code did not get the same update.  It needs the
  same update, and probably the whole raid handling part needs
  upstreamed to Debian.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub-installer/+bug/1771845/+subscriptions