[Bug 1781412] Re: do-release-upgrade crashed with UnboundLocalError in _replaceDebsWithSnaps(): local variable 'proc' referenced before assignment

[Brian Murray]

I no longer receive this crash with the version of ubuntu-release-
upgrader in bionic-proposed.

bdmurray at clean-xenial-amd64:/tmp/u-r-u$ cat DistUpgradeVersion.py 
VERSION = '18.04.21'
bdmurray at clean-xenial-amd64:/tmp/u-r-u$ grep "snap " /var/log/dist-upgrade/main.log 
2018-07-16 11:43:28,581 ERROR No snap store connectivity
2018-07-16 11:44:41,442 DEBUG Install: amd64-microcode apache2-bin apt-config-icons binutils-common binutils-x86-64-linux-gnu bolt cpp-7 cups-ipp-utils dbus-user-session dmsetup e2fsprogs-l10n espeak-ng-data fdisk fonts-beng fonts-beng-extra fonts-deva fonts-deva-extra fonts-droid-fallback fonts-gargi fonts-gubbi fonts-gujr fonts-gujr-extra fonts-indic fonts-kalapi fonts-knda fonts-liberation2 fonts-lohit-beng-assamese fonts-lohit-beng-bengali fonts-lohit-deva fonts-lohit-gujr fonts-lohit-knda fonts-lohit-mlym fonts-lohit-orya fonts-lohit-taml fonts-lohit-taml-classical fonts-lohit-telu fonts-mlym fonts-nakula fonts-navilu fonts-noto-color-emoji fonts-noto-mono fonts-orya fonts-orya-extra fonts-pagul fonts-sahadeva fonts-samyak-deva fonts-samyak-gujr fonts-samyak-mlym fonts-samyak-taml fonts-sarai fonts-smc fonts-smc-anjalioldlipi fonts-smc-chilanka fonts-smc-dyuthi fonts-smc-karumbi fonts-smc-keraleeyam fonts-smc-manjari fonts-smc-meera fonts-smc-rachana fonts-smc-raghumalayalamsans fonts-smc-suruma fonts-smc-uroob fonts-taml fonts-telu fonts-telu-extra fonts-ubuntu g++-7 gcc-7 gcc-7-base gcc-8-base gdm3 geoclue-2.0 gir1.2-accountsservice-1.0 gir1.2-gck-1 gir1.2-gcr-3 gir1.2-gdesktopenums-3.0 gir1.2-gdm-1.0 gir1.2-geoclue-2.0 gir1.2-geocodeglib-1.0 gir1.2-gnomebluetooth-1.0 gir1.2-gnomedesktop-3.0 gir1.2-gweather-3.0 gir1.2-mutter-2 gir1.2-nm-1.0 gir1.2-nma-1.0 gir1.2-polkit-1.0 gir1.2-rsvg-2.0 gir1.2-snapd-1 gir1.2-totemplparser-1.0 gir1.2-upowerglib-1.0 gjs gnome-control-center gnome-control-center-data gnome-control-center-faces gnome-getting-started-docs gnome-initial-setup gnome-keyring-pkcs11 gnome-online-accounts gnome-settings-daemon gnome-shell gnome-shell-common gnome-shell-extension-appindicator gnome-shell-extension-ubuntu-dock gnome-software-plugin-snap gnome-startup-applications gnome-themes-extra gnome-themes-extra-data gnome-todo gnome-todo-common gnome-user-docs gnupg-l10n gnupg-utils gpg gpg-agent gpg-wks-client gpg-wks-server gpgconf gpgsm grilo-plugins-0.3-base gstreamer1.0-gl gstreamer1.0-packagekit gtk-update-icon-cache gtk2-engines-pixbuf gtk3-nocsd hyphen-en-ca hyphen-fi hyphen-ga hyphen-id iio-sensor-proxy imagemagick-6-common indicator-common intel-microcode iucode-tool kerneloops libabw-0.1-1 libapache2-mod-dnssd libappstream4 libapr1 libaprutil1 libaprutil1-dbd-sqlite3 libaprutil1-ldap libargon2-0 libasan4 libbind9-160 libbinutils libblockdev-crypto2 libblockdev-fs2 libblockdev-loop2 libblockdev-part-err2 libblockdev-part2 libblockdev-swap2 libblockdev-utils2 libblockdev2 libboost-date-time1.65.1 libboost-filesystem1.65.1 libboost-iostreams1.65.1 libboost-locale1.65.1 libboost-system1.65.1 libboost-thread1.65.1 libbrotli1 libcairo-gobject-perl libcamel-1.2-61 libcapnp-0.6.1 libcdio-cdda2 libcdio-paranoia2 libcdio17 libcolamd2 libcolord-gtk1 libcom-err2 libcryptsetup12 libcurl4 libdata-dump-perl libdazzle-1.0-0 libdbusmenu-qt5-2 libdns-export1100 libdns1100 libdouble-conversion1 libdw1 libebook-1.2-19 libedataserver-1.2-23 libedataserverui-1.2-2 libefiboot1 libefivar1 libegl-mesa0 libegl1 libepubgen-0.1-1 libespeak-ng1 libevent-2.1-6 libext2fs2 libfastjson4 libfcitx-gclient1 libfreerdp-client2-2 libfreerdp2-2 libfwup1 libfwupd2 libgcc-7-dev libgdbm-compat4 libgdbm5 libgdk-pixbuf2.0-bin libgeoclue-2-0 libgeonames-common libgjs0g libgl1 libgles2 libglib-object-introspection-perl libglvnd0 libglx-mesa0 libglx0 libgmime-3.0-0 libgnome-autoar-0-0 libgnome-desktop-3-17 libgnome-games-support-1-3 libgnome-games-support-common libgnome-todo libgoa-backend-1.0-1 libgpgmepp6 libgraphene-1.0-0 libgrilo-0.3-0 libgspell-1-1 libgspell-1-common libgstreamer-gl1.0-0 libgtk3-nocsd0 libgtk3-perl libgtop-2.0-11 libgweather-3-15 libhunspell-1.6-0 libical3 libicu60 libidn2-0 libip4tc0 libip6tc0 libiptc0 libirs160 libisc-export169 libisc169 libisccc160 libisccfg160 libisl19 libjansson4 libjson-c3 libldap-common liblirc-client0 libllvm6.0 liblouis14 liblouisutdml8 liblua5.3-0 liblwres160 libmagic-mgc libmagickcore-6.q16-3 libmagickcore-6.q16-3-extra libmagickwand-6.q16-3 libmetacity1 libmozjs-52-0 libmp3lame0 libmpfr6 libmpg123-0 libmpx2 libmutter-2-0 libnghttp2-14 libnss-myhostname libnss-systemd libntfs-3g88 liborcus-0.13-0 libpackagekit-glib2-18 libpanel-applet3 libparted-fs-resize0 libpcaudio0 libperl5.26 libphonenumber7 libpng16-16 libpoppler73 libprocps6 libprotobuf-lite10 libprotobuf10 libpsl5 libpython3.6 libpython3.6-minimal libpython3.6-stdlib libqpdf21 libqt5sensors5 libqt5webchannel5 libraw16 libreadline7 libreoffice-gtk2 libreoffice-gtk3 libreoffice-style-tango librhythmbox-core10 libsane1 libsmbios-c2 libsodium23 libssl1.1 libstdc++-7-dev libstemmer0d libsuitesparseconfig5 libsysmetrics1 libteamdctl0 libtracker-sparql-2.0-0 libtry-tiny-perl libtwolame0 libu2f-udev libunistring2 libvolume-key1 libvpx5 libwebp6 libwebpdemux2 libwebpmux3 libwebrtc-audio-processing1 libwinpr2-2 libwoff1 libxapian30 libxcb-res0 libxcb-xinerama0 libxcb-xv0 libxfont2 libxml-libxml-perl libxml-namespacesupport-perl libxml-sax-base-perl libxml-sax-expat-perl libxml-sax-perl libxml-simple-perl libxmlsec1 libxmlsec1-nss libxtables12 libzstd1 linux-headers-4.15.0-23 linux-headers-4.15.0-23-generic linux-image-4.15.0-23-generic linux-modules-4.15.0-23-generic linux-modules-extra-4.15.0-23-generic mutter mutter-common nautilus-extension-gnome-terminal netplan.io network-manager-config-connectivity-ubuntu networkd-dispatcher nplan onboard-common orca packagekit packagekit-tools perl-modules-5.26 perl-openssl-defaults printer-driver-m2300w publicsuffix python3-asn1crypto python3-certifi python3-crypto python3-debconf python3-distro-info python3-distutils python3-keyring python3-keyrings.alt python3-launchpadlib python3-lazr.restfulclient python3-lazr.uri python3-lib2to3 python3-macaroonbakery python3-nacl python3-oauth python3-olefile python3-protobuf python3-pymacaroons python3-requests-unixsocket python3-rfc3339 python3-secretstorage python3-simplejson python3-tz python3-wadllib python3-webencodings python3-yaml python3-zope.interface python3.6 python3.6-minimal qt5-gtk-platformtheme remmina-plugin-secret rhythmbox-plugin-alternative-toolbar sound-icons speech-dispatcher-espeak-ng spice-vdagent system-config-printer ubuntu-advantage-tools ubuntu-report ubuntu-wallpapers-bionic ubuntu-web-launchers unity-session xserver-xephyr xserver-xorg-input-libinput xserver-xorg-legacy xwayland xxd
2018-07-16 12:01:41,269 DEBUG Install of snap gtk-common-themes failed
2018-07-16 12:01:41,285 DEBUG Install of snap gnome-calculator failed
2018-07-16 12:01:41,300 DEBUG Install of snap gnome-characters failed
2018-07-16 12:01:41,315 DEBUG Install of snap gnome-logs failed
2018-07-16 12:01:41,329 DEBUG Install of snap gnome-system-monitor failed


** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1781412

Title:
  do-release-upgrade crashed with UnboundLocalError in
  _replaceDebsWithSnaps(): local variable 'proc' referenced before
  assignment

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed

Bug description:
  Adding support for transitioning debs to snaps when upgrading from
  16.04 to 18.04, bug 1780841, ended up creating a crash in a specific
  scenario.

  [Test Case]
  1) Install and Ubuntu 16.04 desktop system
  2) Modify /etc/hosts so api.snapcraft.io resolves to 127.0.0.1
  3) Upgrade to Ubuntu 18.04 using u-r-u 18.04.20 (sudo ./bionic --frontend DistUpgradeViewText)
  4) Observe the Traceback in this bug report

  N.B. You'll need to manually download and extract the release upgrader
  tarball from http://archive.ubuntu.com/ubuntu/dists/bionic-
  proposed/main/dist-upgrader-all/current/ since the upgrade is to the
  development and proposed release.

  I was testing a release upgrade from Ubuntu 16.04 to Ubuntu 18.04
  where I had no connectivity to the snap store and encountered this
  crash.

  ProblemType: CrashDistroRelease: Ubuntu 18.04
  Package: ubuntu-release-upgrader-core 1:18.04.20
  ProcVersionSignature: Ubuntu 4.4.0-121.145-generic 4.4.117
  Uname: Linux 4.4.0-121-generic x86_64
  ApportVersion: 2.20.9-0ubuntu7.2
  Architecture: amd64
  CrashDB: ubuntu
  Date: Wed Jul 11 20:03:49 2018
  ExecutablePath: /usr/bin/do-release-upgrade
  ExecutableTimestamp: 1531169948
  InstallationDate: Installed on 2016-10-04 (645 days ago)
  InstallationMedia: Ubuntu 16.04.1 LTS "Xenial Xerus" - Release amd64 (20160719)
  InterpreterPath: /usr/bin/python3.5
  PackageArchitecture: all
  ProcCmdline: /usr/bin/python3 ./bionic --frontend DistUpgradeViewText
  ProcCwd: /tmp/u-r-u
  ProcEnviron:
   TERM=screen
   SHELL=/bin/bash
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   LC_CTYPE=en_US.UTF-8
  Python3Details: /usr/bin/python3.6, Python 3.6.5, python3-minimal, 3.6.5-3ubuntu1
  PythonArgs: ['/usr/bin/do-release-upgrade', '--frontend', 'DistUpgradeViewText']
  PythonDetails: /usr/bin/python2.7, Python 2.7.15rc1, python-minimal, 2.7.15~rc1-1SourcePackage: ubuntu-release-upgrader
  Title: do-release-upgrade crashed with UnboundLocalError in _replaceDebsWithSnaps(): local variable 'proc' referenced before assignment
  UpgradeStatus: Upgraded to bionic on 2018-07-12 (0 days ago)
  UserGroups:

  modified.conffile..etc.update-manager.release-upgrades: [modified]
  mtime.conffile..etc.update-manager.release-upgrades: 2016-10-04T13:43:38.934395

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1781412/+subscriptions