[Bug 1316970] Re: g_dbus memory leak in lrmd
Seyeong Kim
seyeong.kim at canonical.com
Wed Feb 21 07:33:01 UTC 2018
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
Please note that patch for pacemaker is created myself.
[Test Case]
- 1. deploy 3 trusty instance.
- 2. install corosync, pacemaker, mysql.
- 3. setting with below info
- 3.1 corosync.conf, proper setting for 3 node
- 3.2 crm configure < setup.crm ( which has upstart:mysql setting )
- 3.3 monitor lrmd daemon's memory usage
+ https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
+ you can check memory leak with this script
[Regression]
- Restarting daemon after upgrading this pkg will be needed. this patch added NULL check for several parts. prior commit[1] changed file structure. and This change makes user changes usage of upstart:mysql to lsb:mysql. So I added free function myself. This might affect to system.
- For glib2.0, commit [1] is critical, but [2],[3],[4] is needed for building it.
+ Restarting daemon after upgrading this pkg will be needed. this patch adds free for non-freed dynamic allocated memory. so it solves memory leak.
[Others]
- Related commits.
+ this patch is from my self with testing.
- [1] commit a7b61e276120184c7586a3217ed3571a982f5017
- Author: Andrew Beekhof <andrew at beekhof.net>
- Date: Fri Aug 23 16:25:35 2013 +1000
-
- Refactor: attrd: Move to its own directory and create a stub for
- attrd-ng
-
- ------------------------------------------------------------------
- $ git describe --contains a1a6922e43dfe80b23887a88401cbb93fe3645c0
- Pacemaker-1.1.11-rc3
-
- $ git describe --contains a7b61e276120184c7586a3217ed3571a982f5017
- Pacemaker-1.1.11-rc1~168
-
- $ rmadison pacemaker
- pacemaker | 1.1.10+git20130802-1ubuntu2 | trusty
- pacemaker | 1.1.10+git20130802-1ubuntu2.4 | trusty-security
- pacemaker | 1.1.10+git20130802-1ubuntu2.4 | trusty-updates
-
- pacemaker | 1.1.14-2ubuntu1 | xenial
- pacemaker | 1.1.14-2ubuntu1.3 | xenial-security
- pacemaker | 1.1.14-2ubuntu1.3 | xenial-update
- pacemaker | 1.1.16-1ubuntu1 | zesty
- pacemaker | 1.1.16-1ubuntu1 | artful
- pacemaker | 1.1.18~rc3-1ubuntu1 | bionic
- ------------------------------------------------------------------
-
- For glib
- [1] https://github.com/GNOME/glib/commit/db641e32920ee8b553ab6f2d318aafa156e4390c
- [2] https://github.com/GNOME/glib/commit/8792609e15394967cab526838b83f90acb401663
- [3] https://github.com/GNOME/glib/commit/ec02a1875f29ecb8e46c0d8c1403cd00a0b3a9e4
- [4] https://github.com/GNOME/glib/commit/f10b6550ff2ce55d06b92d6dc3e443fc007b2f7a
+ Please review carefully if it is ok.
[Original Description]
I'm running Pacemaker 1.1.10+git20130802-1ubuntu1 on Ubuntu Saucy
(13.10) and have encountered a memory leak in lrmd.
The details of the bug are covered here in this thread
(http://oss.clusterlabs.org/pipermail/pacemaker/2014-May/021689.html)
but to summarise, the Pacemaker developers believe the leak is caused by
the g_dbus API, the use of which was removed in Pacemaker 1.11.
I've also attached the Valgrind output from the run that exposed the
issue.
Given that this issue affects production stability (a periodic restart
of Pacemaker is required), will a version of 1.11 be released for
Trusty? (I'm happy to upgrade the OS to Trusty to get it).
If not, can you advise which version of the OS will be the first to take
1.11 please?
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [1]
Please note that patch for pacemaker is created myself.
[Test Case]
https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
you can check memory leak with this script
[Regression]
- Restarting daemon after upgrading this pkg will be needed. this patch adds free for non-freed dynamic allocated memory. so it solves memory leak.
+ Restarting daemon after upgrading this pkg will be needed. this patch adds free for non-freed dynamic allocated memory. so it solves memory leak.
[Others]
this patch is from my self with testing.
Please review carefully if it is ok.
+
+ [1] https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741
[Original Description]
I'm running Pacemaker 1.1.10+git20130802-1ubuntu1 on Ubuntu Saucy
(13.10) and have encountered a memory leak in lrmd.
The details of the bug are covered here in this thread
(http://oss.clusterlabs.org/pipermail/pacemaker/2014-May/021689.html)
but to summarise, the Pacemaker developers believe the leak is caused by
the g_dbus API, the use of which was removed in Pacemaker 1.11.
I've also attached the Valgrind output from the run that exposed the
issue.
Given that this issue affects production stability (a periodic restart
of Pacemaker is required), will a version of 1.11 be released for
Trusty? (I'm happy to upgrade the OS to Trusty to get it).
If not, can you advise which version of the OS will be the first to take
1.11 please?
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
Status in glib2.0 package in Ubuntu:
New
Status in pacemaker package in Ubuntu:
Fix Released
Status in glib2.0 source package in Trusty:
New
Status in pacemaker source package in Trusty:
In Progress
Bug description:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [1]
Please note that patch for pacemaker is created myself.
[Test Case]
https://pastebin.ubuntu.com/p/fqK6Cx3SKK/
you can check memory leak with this script
[Regression]
Restarting daemon after upgrading this pkg will be needed. this patch adds free for non-freed dynamic allocated memory. so it solves memory leak.
[Others]
this patch is from my self with testing.
Please review carefully if it is ok.
[1] https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1750741
[Original Description]
I'm running Pacemaker 1.1.10+git20130802-1ubuntu1 on Ubuntu Saucy
(13.10) and have encountered a memory leak in lrmd.
The details of the bug are covered here in this thread
(http://oss.clusterlabs.org/pipermail/pacemaker/2014-May/021689.html)
but to summarise, the Pacemaker developers believe the leak is caused
by the g_dbus API, the use of which was removed in Pacemaker 1.11.
I've also attached the Valgrind output from the run that exposed the
issue.
Given that this issue affects production stability (a periodic restart
of Pacemaker is required), will a version of 1.11 be released for
Trusty? (I'm happy to upgrade the OS to Trusty to get it).
If not, can you advise which version of the OS will be the first to
take 1.11 please?
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+subscriptions
More information about the foundations-bugs
mailing list