[Bug 1807978] Re: vmtest: iscsi/LVM tests failing on cosmic/disco

[Brian Murray]

Hello Ryan, or anyone else affected,

Accepted open-iscsi into cosmic-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/open-
iscsi/2.0.874-5ubuntu9.3 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-cosmic to verification-done-cosmic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-cosmic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: open-iscsi (Ubuntu Cosmic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-cosmic

** Changed in: open-iscsi (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1807978

Title:
  vmtest: iscsi/LVM tests failing on cosmic/disco

Status in curtin package in Ubuntu:
  Invalid
Status in open-iscsi package in Ubuntu:
  Triaged
Status in curtin source package in Bionic:
  Invalid
Status in open-iscsi source package in Bionic:
  Fix Committed
Status in curtin source package in Cosmic:
  Invalid
Status in open-iscsi source package in Cosmic:
  Fix Committed

Bug description:
  === Begin SRU Template ===
  [Impact]
  This bug results in lvm devices on top of iscsi block devices not being
  available to the system.  The journal will show messages like:
    [ 17.666655] systemd[1]: dev-disk-by\x2duuid-a98f706b\x2db064\x2d4682\x2d8eb2\x2d6c2c1284060c.device: Dependency Before=network-online.target ignored (.device units cannot be delayed)

  And ultimately 
   TIME [0m] Timed out waiting for device dev-di...device.

  [Test Case]
  This can be tested by running curtin's vmtest test harness.
  A run like this should suffice:

  env CURTIN_VMTEST_ADD_REPOS=proposed \
      CURTIN_VMTEST_UPGRADE_PACKAGES=open-iscsi \
      ./tools/jenkins-runner \
         tests/vmtests/test_iscsi.py  \
         tests/vmtests/test_lvm_iscsi.py  \
         tests/vmtests/test_mdadm_iscsi.py \
         tests/vmtests/test_basic.py

  That is all the iscsi based tests and a 'basic' install for good
  measure.

  [Regression Potential]
  Chance of regression is hopefully low, and hopefully lower now than before.
  Regression is almost certainly limited to iscsi devices.

  [Other Info]
  An attempt to fix bug 1802354 added a udev rule for open-iscsi that looked
  like:
    SUBSYSTEM=="block", ACTION=="add", ENV{ID_PATH}=="*-iscsi-*", ENV{SYSTEMD_WANTS}="iscsid.service"

  The problem was ENV{SYSTEMD_WANTS}="iscsid.service".

  The '=' operator would truncate the udev-added "wants".  lvm also utilized
  SYSTEMD_WANTS, and the two would conflict.

  This is the second regression fix to the open-iscsi package as a result
  of the fix for bug 1755858.

  The regression was caught by curtin's test harness (vmtest).  Specifically
  the following tests would fail:

   tests/vmtests/test_lvm_iscsi.py:BionicTestIscsiLvm
   tests/vmtests/test_lvm_iscsi.py:CosmicTestIscsiLvm
   tests/vmtests/test_lvm_iscsi.py:DiscoTestIscsiLvm

  Related Bugs:
   * bug 1755858: iscsid autostarts on all servers when it has nothing to do 
   * bug 1802354: vmtest: iscsi tests failing on cosmic/disco 
  === End SRU Template ===

  TestIscsiBasic and other Iscsi tests on Cosmic/Disco are failing in
  vmtest on jenkins.

    - looked some at curtin at iscsi failures cosmic, disco
      - 604 was first fail like this.
             cosmic 20181204
             disco  20181129
        https://jenkins.ubuntu.com/server/job/curtin-vmtest-devel-amd64/604/consoleFull
        602 PASSED and did run disco
             cosmic 20181114
             disco  20181109

      - seems likely tied to open-iscsi upload https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1755858 or https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1802354
    I want to revert iscsi and see if it fixes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1807978/+subscriptions