[Bug 1807288] Re: mkfs.ext4 -d $directory_with_acls leads to EINVAL

[Brian Murray]

Hello Michael, or anyone else affected,

Accepted e2fsprogs into cosmic-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/e2fsprogs/1.44.4-2ubuntu0.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-cosmic to verification-done-cosmic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-cosmic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: e2fsprogs (Ubuntu Cosmic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-cosmic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to e2fsprogs in Ubuntu.
https://bugs.launchpad.net/bugs/1807288

Title:
  mkfs.ext4 -d $directory_with_acls leads to EINVAL

Status in e2fsprogs package in Ubuntu:
  Fix Released
Status in e2fsprogs source package in Bionic:
  New
Status in e2fsprogs source package in Cosmic:
  Fix Committed
Status in e2fsprogs source package in Disco:
  Fix Released

Bug description:
  [Justification]
  `mkfs.ext4 -d` can produce broken filesystems when there are acls in the tree used as input.

  [Test case]
  1. dd if=/dev/zero count=0 bs=1M seek=100 of=./fake.img
  2. mkdir -p stuff/journal
  3. setfacl -m g:adm:rwx stuff/journal
  4. mkfs.ext4 -L lala -O -metadata_csum -T default -O uninit_bg fake.img -d ./stuff/
  5. sudo mount ./fake.img /mnt
  6. Verify that `getfacl /mnt/journal/` returns an error.
  7. sudo umount /mnt
  8. install libext2fs2 from -proposed.
  9. mkfs.ext4 -L lala -O -metadata_csum -T default -O uninit_bg fake.img -d ./stuff/
  10. sudo mount ./fake.img /mnt
  11. Verify that `getfacl /mnt/journal/` returns acl information, not an error.
  12. sudo umount /mnt

  [Original description]

  This looks an awful lot like bug 1645232 but that is claimed to be
  fixed:

  mwhudson at ringil:~/tmp$ mkfs.ext4 -V
  mke2fs 1.44.1 (24-Mar-2018)
   Using EXT2FS Library version 1.44.1
  mwhudson at ringil:~/tmp$ dd if=/dev/zero count=0 bs=1M seek=100 of=./fake.img
  0+0 records in
  0+0 records out
  0 bytes copied, 0.0015871 s, 0.0 kB/s
  mwhudson at ringil:~/tmp$ mkdir -p stuff/journal
  mwhudson at ringil:~/tmp$ setfacl -m g:adm:rwx stuff/journal
  mwhudson at ringil:~/tmp$ mkfs.ext4 -L lala -O -metadata_csum -T default -O uninit_bg fake.img -d ./stuff/
  mke2fs 1.44.1 (24-Mar-2018)
  Discarding device blocks: done
  Creating filesystem with 25600 4k blocks and 6400 inodes

  Allocating group tables: done
  Writing inode tables: done
  Creating journal (1024 blocks): done
  Copying files into the device: done
  Writing superblocks and filesystem accounting information: done

  mwhudson at ringil:~/tmp$ sudo mount ./fake.img /mnt
  mwhudson at ringil:~/tmp$ getfacl /mnt/journal/
  getfacl: /mnt/journal/: Invalid argument

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/e2fsprogs/+bug/1807288/+subscriptions