[Bug 1767454]

[Harald Sitter]

Git commit 55eb68ff63646050311f8b689752ad500246c916 by Harald Sitter.
Committed on 07/12/2018 at 12:55.
Pushed by sitter into branch 'master'.

fallback to dnssd service discovery if smb listDir failed on root

Summary:
This elevates a problem with newer SMB protocol versions and smbclient
not supporting discovery/browsing. when not using older (as in:
ancient) protocol versions discovery doesn't work and smb:/ gives no
results.

By falling back to DNSSD based discovery we can ensure discovery of DNSSD
remotes (namely linux and osx) is always working. Windows unfortunately
does not support DNSSD and as such will not benefit from this mode of
discovery and continue to be unlisted when using a protocol version
without browsing support.

CHANGELOG: When SMB Discovery is not working (protocol > SMB1) host discovery will now fall back to DNS-SD/Avahi/Bonjour.
Related: bug 390551

Test Plan:
smb.conf:

```
[global]
client min protocol = SMB2
```

Lists devices

Reviewers: #frameworks, #dolphin, broulik

Reviewed By: broulik

Subscribers: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-
devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D16299

M  +6    -0    CMakeLists.txt
M  +3    -0    config-runtime.h.cmake
M  +16   -3    smb/CMakeLists.txt
M  +1    -0    smb/kio_smb.h
M  +126  -3    smb/kio_smb_browse.cpp

https://commits.kde.org/kio-
extras/55eb68ff63646050311f8b689752ad500246c916

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to samba in Ubuntu.
https://bugs.launchpad.net/bugs/1767454

Title:
  "Other Locations" does not automatically find Samba servers in Ubuntu
  18.04

Status in dolphin:
  Unknown
Status in gvfs:
  Fix Released
Status in OEM Priority Project:
  New
Status in samba:
  Unknown
Status in gvfs package in Ubuntu:
  Fix Released
Status in samba package in Ubuntu:
  Invalid

Bug description:
  Ubuntu: 18.04 clean install
  Nautilus: 1:3.26.3-0ubuntu4

  The actions taken to produce the problem:
  Click on “Other Locations” in Nautilus.

  The expected result of these actions:
  Samba servers to automatically show up under “Networks”. This is the behavior in Ubuntu 17.10 using Nautilus 1:3.26.0-0ub. Also, clicking on “”Windows Network” immediately shows "Folder is Empty".

  The actual result of these actions:
  The Samba servers never show up under “Networks” and clicking on "Windows Network" always immediately comes up with "Folder is Empty".

  Further information:
  This happens on both machines with a clean Ubuntu 18.04 install. My Ubuntu 17.10 machines still work like expected.

  I can still manually type in the Samba information in "Connect to
  Server" and the 18.04 machines connect just fine.

  
  From syslog:
  Apr 27 13:49:34 david-HP-ProBook-440-G2 dbus-daemon[1333]: [session uid=1000 pid=1333] Activating service name='org.gnome.Nautilus' requested by ':1.13' (uid=1000 pid=1468 comm="/usr/bin/gnome-shell " label="unconfined")
  Apr 27 13:49:34 david-HP-ProBook-440-G2 dbus-daemon[1333]: [session uid=1000 pid=1333] Successfully activated service 'org.gnome.Nautilus'
  Apr 27 13:49:35 david-HP-ProBook-440-G2 dbus-daemon[754]: [system] Activating via systemd: service name='org.freedesktop.hostname1' unit='dbus-org.freedesktop.hostname1.service' requested by ':1.131' (uid=1000 pid=4857 comm="/usr/bin/nautilus --gapplication-service " label="unconfined")
  Apr 27 13:49:35 david-HP-ProBook-440-G2 systemd[1]: Starting Hostname Service...
  Apr 27 13:49:35 david-HP-ProBook-440-G2 nautilus[4857]: Called "net usershare info" but it failed: Failed to execute child process “net” (No such file or directory)
  Apr 27 13:49:35 david-HP-ProBook-440-G2 dbus-daemon[754]: [system] Successfully activated service 'org.freedesktop.hostname1'
  Apr 27 13:49:35 david-HP-ProBook-440-G2 systemd[1]: Started Hostname Service.
  Apr 27 13:49:40 david-HP-ProBook-440-G2 gvfsd[1432]: mkdir failed on directory /var/cache/samba: Permission denied

To manage notifications about this bug go to:
https://bugs.launchpad.net/dolphin/+bug/1767454/+subscriptions