[Bug 1805841] Proposed quick fix

[bugproxy]

------- Comment on attachment From cborntra at de.ibm.com 2018-12-03 08:05 EDT-------


This would be a quick fix that let cpictl fully handle the kernel level, while s390-cpi-vars would still be active as today for the remaining things.
Works for me.

Of course this is only a partial step that restores some of the cpictl
functionality. Long term we must integrate s390-cpi-vars somehow in
cpictl.

** Attachment added: "Proposed quick fix"
   https://bugs.launchpad.net/bugs/1805841/+attachment/5218458/+files/cpifix.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to s390-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1805841

Title:
  CPI information about kvm usage is lost during apt upgrade

Status in Ubuntu on IBM z Systems:
  Triaged
Status in s390-tools package in Ubuntu:
  New

Bug description:
  ---Problem Description---
  CPI information about kvm usage is lost during apt upgrade
   
  ---uname output---
  4.15.0-42-generic
   
  Machine Type = s390x lpar  
   
  ---Steps to Reproduce---

  # cat /sys/firmware/cpi/*
  cat: /sys/firmware/cpi/set: Permission denied
          
  0x0000000000040f00
          
  LINUX   
  root at m83lp52:~# virsh start guest   # starting a guest does set the highest bit in
  /sys/firmware/cpi/system_leveln  

  root at m83lp52:~# cat /sys/firmware/cpi/*
  cat: /sys/firmware/cpi/set: Permission denied
          
  0x8000000000040f00   <---- see the 8
          
  LINUX  

  root at m83lp52:~# apt upgrade
  [....]
  has to upgrade at least one package, that will trigger some other code.
  [....]

  Now. some other code seems to have set values in /sys/firmware/cpi as
  well dropping the kvm information.

  root at m83lp52:~# cat /sys/firmware/cpi/*
  cat: /sys/firmware/cpi/set: Permission denied
  18 04 1  
  0x0000000000040f00
  UBUNTU  
  LINUX  

  
  The canonical place to handle /sys/firmware/cpi should be /lib/s390-tools/cpictl and /lib/systemd/system/cpi.service. So can we put the additional features (setting 18 04 1 and UBUNTU things also into
  /etc/sysconfig/cpi
  or
  /lib/s390-tools/cpictl
  )
  and can we disable the other code that also sets /sys/firmware/cpi (I have not found out which code sets these values). This seems to be /lib/systemd/system-generators/s390-cpi-vars

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1805841/+subscriptions