[Bug 1785165] Re: firmware update on fwupdate version 10-3 not work on some AMI's firmwares

[Ivan Hu]

@Mario,
Actually I have built a test package 10-3.3 on my test PPA, https://launchpad.net/~ivan.hu/+archive/ubuntu/test.ppa, base on 10-3 and with the only fixed patch, and got confirmed that can fix the fwupdate issue from OEM. What other patches do you think we also need to SRU?

I also tested with Dell XPS machine which has no such issue originally,
and it could do the firmware update successfully, not affected by this
patch.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to fwupdate in Ubuntu.
https://bugs.launchpad.net/bugs/1785165

Title:
  firmware update on fwupdate version 10-3 not work on some AMI's
  firmwares

Status in fwupdate package in Ubuntu:
  New
Status in fwupdate-signed package in Ubuntu:
  New

Bug description:
  [Rationale]
  The commited patch, Handle ux capsule updates, https://github.com/rhboot/fwupdate/commit/2561423dd68622dcf8a7542709f332edb517d34e, change to calculate CapsuleBlockDesc Length = CapsuleHeader.CapsuleImageSize + HeaderSize, but on AMI BIOS image which is without capsule header. Fwudpate package on 18.04(version 10-3) included the "Handle ux capsule updates" causes those machine with AMI firmware cannot do firmware update.
  The fixed patch have been committed, https://github.com/rhboot/fwupdate/commit/863db45c246acd2cbeff0b4e32d3a8312475ff6a and fix the incorrect cbd_length.

  [Impact]
  Machines with AMI's firmware cannot do firmware update.

  [Test cases]
  1. install ubuntu 18.04 on AMI's bios machine.
  2. get the update firmware
  3. See if this machine support firmware update,
     #sudo fwudpate -s
  4. get the update GUID
     #sudo fwupdate -l
  5. do firmeare update
     #sudo -a GUID  firmware.bin
  6. reboot

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwupdate/+bug/1785165/+subscriptions