[Bug 1766261] Re: Upgrading prompts for Secure Boot password when I dont have DKMS modules nor virtualbox

[Steve Langasek]

Thanks for the report.  This is indeed a regression affecting only those
users who have the dkms package installed but not any dkms module
packages.

The previous incarnation of the code did:

 dkms_list=$(find /var/lib/dkms -maxdepth 1 -type d -print 2>/dev/null \
             | LC_ALL=C sort)
 dkms_modules=$(echo "$dkms_list" | wc -l)

 if [ $dkms_modules -gt 1 ] || [ $enable_secureboot -eq 1 ]; then
        echo "$dkms_list" > $NEW_DKMS_LIST
        setup_mok_validation $enable_secureboot
        mv "$NEW_DKMS_LIST" "$OLD_DKMS_LIST"
 else
        echo "No DKMS packages installed: not changing Secure Boot validation state."
 fi

This check of [ $dkms_modules -gt 1 ] is lost in the current iteration,
we now don't use the value of $dkms_modules at all.  We should be making
sure we are silent if there are no dkms modules present and SecureBoot
is already enabled.


** Changed in: shim-signed (Ubuntu)
   Importance: Undecided => Medium

** Changed in: shim-signed (Ubuntu)
       Status: New => Triaged

** Changed in: shim-signed (Ubuntu)
     Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to shim-signed in Ubuntu.
https://bugs.launchpad.net/bugs/1766261

Title:
  Upgrading prompts for Secure Boot password when I dont have DKMS
  modules nor virtualbox

Status in shim-signed package in Ubuntu:
  Triaged

Bug description:
  Upgrading prompts for Secure Boot password, but I don't have
  VirtualBox nor a DKMS driver installed (Although, I do have DKMS
  itself installed):

  # For VirtualBox:
  roaksoax at rivals:/var/lib/dkms$ sudo modinfo vboxdrv
  modinfo: ERROR: Module vboxdrv not found.
  roaksoax at rivals:/var/lib/dkms$ sudo modinfo vboxnetflt
  modinfo: ERROR: Module vboxnetflt not found.
  roaksoax at rivals:/var/lib/dkms$ lsmod | grep vbox
  roaksoax at rivals:/var/lib/dkms$ 

  # For DKMS:
  1 roaksoax at rivals:/var/lib/dkms$ dpkg -l | grep dkms
  ii  dkms                                       2.3-3ubuntu7                                 all          Dynamic Kernel Module Support Framework

  roaksoax at rivals:/var/lib/dkms$ cat /var/lib/shim-signed/dkms-list 
  /var/lib/dkms

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shim-signed/+bug/1766261/+subscriptions