[Bug 1762889] Re: dh_translations doesn't strip .desktop files when more than 1 pot target with meson

[Gunnar Hjalmarsson]

I think the attached debdiff changes dh_translations in accordance with
the above discussion.

With all the workarounds in debian/rules dropped, g-c-c fails as
expected. But with this:

override_dh_translations:
	dh_translations --domain=gnome-control-center-2.0

both the POT creation and the rest work fine.

gnome-calculator creates the POT and tweaks the .desktop file nicely
without any overrides.

I took this opportunity to propose that also Icon and Keywords
translations are stripped. Hope you agree that that makes sense.

** Patch added: "pkgbinarymangler_lp1762889.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+attachment/5111445/+files/pkgbinarymangler_lp1762889.debdiff

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/1762889

Title:
  dh_translations doesn't strip .desktop files when more than 1 pot
  target with meson

Status in pkgbinarymangler package in Ubuntu:
  In Progress

Bug description:
  The gnome.help() meson function creates a help-$project-pot target.
  This confuses dh_translations which complains:

  dh_translations: more than one meson translation domain found (help-
  gnome-calculator,gnome-calculator), don't know which one to use

  I think the only consequence of this is that the .desktop doesn't have
  its translations stripped and replaced with X-Ubuntu-Gettext-Domain=

  This means that Ubuntu translators are unable to update those
  translations.

  Affected Apps
  =============
  Therefore, this issue affects GNOME apps in main that use meson and also include help files.

  gnome-control-center is also affected because it happens to have an
  extra gettext domain (but does not ship help).

  libgweather gets the warning because it has a second gettext domain
  but it doesn't ship any .desktop files so I think the warning is
  harmless.

  Suggestion
  ==========
  Maybe dh_translations could just exclude targets that start with "help-". That would fix most of these cases.

  Other Info
  ==========
  This bug is split off LP: #1751820

  pkgbinarymanagler 136 in bionic

  References
  ==========
  http://mesonbuild.com/Gnome-module.html#gnomeyelp
  http://mesonbuild.com/Localisation.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+subscriptions