[Bug 1762889] Re: dh_translations doesn't strip .desktop files when more than 1 pot target with meson

[Iain Lane]

On Wed, Apr 11, 2018 at 10:37:11AM -0000, Gunnar Hjalmarsson wrote:
> > I don't like this - it puts the information in a hard to find place
> > that's remote from the packages it refers to. I think this should be
> > in the rules file for the affected projects, maybe
> > 
> >   $ dh_translations --ignore-domain=gnome-control-center-2.0-timezones
> > 
> > and documented in the manpage. Ideally you'd be able to specify that
> > option multiple times.
> Yeah, calling dh_translations with options is the other way. To be honest I started to think about that (bug #1762728) but couldn't figure out how to do it. Can you give a hint about how to add an option with arguments to a dh_* script? (I know about @ARGV, but in this case things happen behind the scenes which I don't understand.)

Sure, you can look at other dh_* for examples of this. For example
dh_strip has a --dbgsym-migration option. See the init() call.

> If we figure out how to add an option, I think it would be much easier
> to state the domain we want instead of a list of domains to ignore:
> 
>    $ dh_translations --domain=gnome-control-center-2.0
> 
> So as regards your concern about ignoring too much by only looking for
> 'help-', I'd suggest we leave that for now. With an option as above, we
> can drop 'the ignore approach'.

It'd be best if dh_translations was able to work automatically most of
the time.

It would appear that a normal case is to have a foo-po and a
help-$project-po target. It should be possible, using the method I
outlined, to handle this out of the box without requiring an override in
d/rules.

For the rest, I suppose it doesn't really matter if you handle outliers
with a --domain or a --ignore option, so I'll leave that bit up to you.

Cheers,

-- 
Iain Lane                                  [ iain at orangesquash.org.uk ]
Debian Developer                                   [ laney at debian.org ]
Ubuntu Developer                                   [ laney at ubuntu.com ]

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/1762889

Title:
  dh_translations doesn't strip .desktop files when more than 1 pot
  target with meson

Status in pkgbinarymangler package in Ubuntu:
  New

Bug description:
  The gnome.help() meson function creates a help-$project-pot target.
  This confuses dh_translations which complains:

  dh_translations: more than one meson translation domain found (help-
  gnome-calculator,gnome-calculator), don't know which one to use

  I think the only consequence of this is that the .desktop doesn't have
  its translations stripped and replaced with X-Ubuntu-Gettext-Domain=

  This means that Ubuntu translators are unable to update those
  translations.

  Affected Apps
  =============
  Therefore, this issue affects GNOME apps in main that use meson and also include help files.

  gnome-control-center is also affected because it happens to have an
  extra gettext domain (but does not ship help).

  libgweather gets the warning because it has a second gettext domain
  but it doesn't ship any .desktop files so I think the warning is
  harmless.

  Suggestion
  ==========
  Maybe dh_translations could just exclude targets that start with "help-". That would fix most of these cases.

  Other Info
  ==========
  This bug is split off LP: #1751820

  pkgbinarymanagler 136 in bionic

  References
  ==========
  http://mesonbuild.com/Gnome-module.html#gnomeyelp
  http://mesonbuild.com/Localisation.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/1762889/+subscriptions