[Bug 1705538] Comment bridged from LTC Bugzilla

Wed Sep 20 15:17:55 UTC 2017

On Wed, Sep 20, 2017 at 11:09:56AM -0000, bugproxy wrote:
> (In reply to comment #5)
> > For 17.10, I've attempted to upload the 1.1.18 upstream version rather than
> > cherry-picking individual fixes.  However, the package fails to build on the
> > Ubuntu builders due to a series of bugs.

> > - when the test binary is built, it is linked against libservicelog.so, not
> > libservicelog.la.  This means that there is no libtool wrapper script to set
> > the path; and the test binary only ever works if there is an
> > already-installed version of libservicelog on the system path which is being
> > tested instead of the just-built version.
> > - if servicelog_open() returns a failure, test_libservicelog segfaults
> > because it tries to dereference a null pointer.
> > - if /var/lib/libservicelog/ does not already exist on the system,
> > servicelog_open() will *always* fail.

> > I've written patches for the first two issues;

> Thanks for the patch. I didn't see your s-o-b in patch. Do you have any
> objection in adding your s-o-b and merging these patches in upstream?

The two patches are attached to the bug log in Launchpad:

https://bugs.launchpad.net/ubuntu/+source/libservicelog/+bug/1705538/+attachment/4940508/+files/0001-Use-libtool-dependencies-for-linking-tests.patch
https://bugs.launchpad.net/ubuntu/+source/libservicelog/+bug/1705538/+attachment/4940509/+files/0002-Fix-segfault-on-servicelog_open-failure.patch

No objections to these being merged upstream.  If you need something formal
from Canonical regarding copyright / license, please let me know.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to libservicelog in Ubuntu.
https://bugs.launchpad.net/bugs/1705538

Title:
  Update Package request for libservicelog

Status in The Ubuntu-power-systems project:
  New
Status in libservicelog package in Ubuntu:
  Fix Released
Status in libservicelog source package in Xenial:
  New

Bug description:
  ---Problem Description---
  Update Package request for libservicelog

  Machine Type = lpar 

  ---Steps to Reproduce---
   servicelog --dump

  ---uname output---
  Linux tuleta4u-lp9 4.10.0-27-generic #30~16.04.2-Ubuntu SMP Thu Jun 29 16:06:52 UTC 2017 ppc64le ppc64le ppc64le GNU/Linux 

  Please pull below mentioned patches for libservicelog package

  commit 4fe9d9239f172604e16268ca1fb6fff1c06632b2
  Author: Ankit Kumar <ankit at linux.vnet.ibm.com>
  Date:   Sat May 20 01:38:41 2017 +0530

      Validate text string before and after bind call

      While binding string to query, if string is NULL then bind call gets ignored.
      While fetching data from string, if data is NULL then current code makes query
      as NULL and returns.

      This patch validates text string before and after bind call. It assigns string
      to "" incase data is NULL points to NULL pointer. After this we will be able
      to display information even if some of string data is NULL.

      It also does NULL checks for compulsory string.

      Signed-off-by: Ankit Kumar <ankit at linux.vnet.ibm.com>
      [Killed redundant goto statements - Vasant]
      Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

  commit 787594814eb88e3149cd660bcb6aaa6d3dd1347c
  Author: Ankit Kumar <ankit at linux.vnet.ibm.com>
  Date:   Sat May 20 01:10:49 2017 +0530

      Correct string length calculation and validates destination buffer size before strncpy

      This patch corrects string length calculation logic and validates destination
      buffer size before calling strncpy to avoid memory corruption.

      Signed-off-by: Ankit Kumar <ankit at linux.vnet.ibm.com>
      [Moved memset to right place and removed redundant condition check -
       Vasant]
      Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

  commit 48875ee8614eeefaa3d5d8ff92fb424915738169
  Author: Ankit Kumar <ankit at linux.vnet.ibm.com>
  Date:   Thu Sep 15 16:16:49 2016 +0530

      NULL check before strdup call

      This patch does "NULL checks" before passing argument to strdup call.

      Signed-off-by: Ankit Kumar <ankit at linux.vnet.ibm.com>
      Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

  commit 40b4f7a52e61fb9da30b4cb9b5de9a85673da262
  Author: Ankit Kumar <ankit at linux.vnet.ibm.com>
  Date:   Thu Sep 15 16:16:48 2016 +0530

      NULL check before strlen call

      This patch checks NULL pointer before strlen call.

      Signed-off-by: Ankit Kumar <ankit at linux.vnet.ibm.com>
      [Fixed build warning - Vasant]
      Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1705538/+subscriptions