[Bug 1699789] Re: Regression: Installing Landscape from chroot hangs (on install iso)

[Andreas Hasenack]

** Description changed:

  [Impact]
  
  Handle SystemExit exception, as those don't propagate past the reactor.
  
  It is hanging forever in environments (installer-chroot) where the
  broker will not start.
  
  [Test Case]
  
  To test:
  
- $ ln -s /bin/echo /etc/init.d/landscape-client && sudo landscape-config
- --silent
+ sudo rm /etc/init.d/landscape-client
+ sudo ln -s /bin/echo /etc/init.d/landscape-client
+ sudo time landscape-config -a someaccount -t sometitle --silent
  
- Script should timeout and not run forever.
+ Script should timeout and not run forever. The time it takes to timeout
+ unfortunately varies a lot, but is usually between 1 and 3 minutes.
  
  [Regression Potential]
  
  The change restores the same logic which was used before this
  regression, which should be safe.
  
  As the code change is only used for initialization of the service after calling the configuration tool, regression in this area would force the
  admin to restart the landscape-client service manually after calling landscape-config if that tool is used.
  
  [Other Info]
  
  * GitHub PR :
  https://github.com/CanonicalLtd/landscape-client/pull/13
  
  * Upstream commit :
  https://github.com/CanonicalLtd/landscape-client/commit/e0b1b0ca43c13bc65374df13d192405abb3014e6
  
  Stop reactor in landscape-config on broker error
  Handle SystemExit exception, as those don't propagate past the reactor, in order to avoid getting stuck when installed in chroot.
  
  [Original Description]
  
  Ubuntu Xenial installer (ubuntu-16.04.2-server-amd64.iso) doesn't offer
  option to provide http/https proxy to be used by Landscape client when
  selecting "Manage system with Landscape" on upgrades management tasksel
  question.
  
  Therefore if system is placed behind proxy it will not be able to
  communicate with landscapce server.
  
  During system installation installer is asking user to provide proxy
  that is used by APT. It would be suitable that same proxy would be used
  for landscape.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to debian-installer in Ubuntu.
https://bugs.launchpad.net/bugs/1699789

Title:
  Regression: Installing Landscape from chroot hangs (on install iso)

Status in Landscape Client:
  Fix Committed
Status in debian-installer package in Ubuntu:
  Confirmed
Status in landscape-client package in Ubuntu:
  Fix Released
Status in debian-installer source package in Trusty:
  New
Status in landscape-client source package in Trusty:
  New
Status in debian-installer source package in Xenial:
  New
Status in landscape-client source package in Xenial:
  New
Status in debian-installer source package in Zesty:
  New
Status in landscape-client source package in Zesty:
  New
Status in debian-installer source package in Artful:
  New
Status in landscape-client source package in Artful:
  New

Bug description:
  [Impact]

  Handle SystemExit exception, as those don't propagate past the
  reactor.

  It is hanging forever in environments (installer-chroot) where the
  broker will not start.

  [Test Case]

  To test:

  sudo rm /etc/init.d/landscape-client
  sudo ln -s /bin/echo /etc/init.d/landscape-client
  sudo time landscape-config -a someaccount -t sometitle --silent

  Script should timeout and not run forever. The time it takes to
  timeout unfortunately varies a lot, but is usually between 1 and 3
  minutes.

  [Regression Potential]

  The change restores the same logic which was used before this
  regression, which should be safe.

  As the code change is only used for initialization of the service after calling the configuration tool, regression in this area would force the
  admin to restart the landscape-client service manually after calling landscape-config if that tool is used.

  [Other Info]

  * GitHub PR :
  https://github.com/CanonicalLtd/landscape-client/pull/13

  * Upstream commit :
  https://github.com/CanonicalLtd/landscape-client/commit/e0b1b0ca43c13bc65374df13d192405abb3014e6

  Stop reactor in landscape-config on broker error
  Handle SystemExit exception, as those don't propagate past the reactor, in order to avoid getting stuck when installed in chroot.

  [Original Description]

  Ubuntu Xenial installer (ubuntu-16.04.2-server-amd64.iso) doesn't
  offer option to provide http/https proxy to be used by Landscape
  client when selecting "Manage system with Landscape" on upgrades
  management tasksel question.

  Therefore if system is placed behind proxy it will not be able to
  communicate with landscapce server.

  During system installation installer is asking user to provide proxy
  that is used by APT. It would be suitable that same proxy would be
  used for landscape.

To manage notifications about this bug go to:
https://bugs.launchpad.net/landscape-client/+bug/1699789/+subscriptions