[Bug 1694697] Re: build-depends keeps OR flag if end of or group is ignored
Launchpad Bug Tracker
1694697 at bugs.launchpad.net
Wed May 31 21:38:45 UTC 2017
This bug was fixed in the package apt - 1.4.5
---------------
apt (1.4.5) unstable; urgency=medium
* Fix parsing of or groups in build-deps with ignored packages (LP:
#1694697)
-- Julian Andres Klode <jak at debian.org> Wed, 31 May 2017 14:52:25
+0200
** Changed in: apt (Ubuntu)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1694697
Title:
build-depends keeps OR flag if end of or group is ignored
Status in apt package in Ubuntu:
Fix Released
Bug description:
[Impact]
If the last alternative(s) of an Or group is ignored, because it does
not match an architecture list, we would end up keeping the or flag,
effectively making the next AND an OR.
For example, when parsing (on amd64):
debhelper (>= 9), libnacl-dev [amd64] | libnacl-dev [i386]
=> debhelper (>= 9), libnacl-dev |
Which can cause python-apt and apt-get build-dep to crash.
Even worse:
debhelper (>= 9), libnacl-dev [amd64] | libnacl-dev [i386], foobar
=> debhelper (>= 9), libnacl-dev [amd64] | foobar
[Test case]
On amd64:
cat > segv.dsc << EOF
Format: 3.0 (native)
Source: foobar
Binary: foobar
Architecture: all
Version: 1
Maintainer: Joe Sixpack <joe at example.org>
Build-Depends: build-essential [amd64] | build-essential [fancy]
Standards-Version: 3.9.8
EOF
cat > failure.dsc << EOF
Format: 3.0 (native)
Source: foobar
Binary: foobar
Architecture: all
Version: 1
Maintainer: Joe Sixpack <joe at example.org>
Build-Depends: build-essential [amd64] | build-essential [fancy], a-non-existing-package
Standards-Version: 3.9.8
EOF
(1) apt-get build-dep -s ./segv.dsc should succeed instead of crash
(2) apt-get build-dep -s ./failure.dsc should complain about "Depends: a-non-existing-package but it is not installable" instead of succeeding.
This is the same test as run by CI and autopkgtests, so if they pass
the tests passed. You can also run apt-get build-dep -s dq for a real
life example that should not segfault.
[Regression Potential]
apt-get build-dep and friends can now fail where they succeeded previously for packages that employ architecture-limited alternatives in their build depends, as in the second example given above, because now additional packages need to be installed (which is correct, though).
[Other info]
By setting the previous alternatives Or flag to the current Or flag
if the current alternative is ignored, we solve the issue.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1694697/+subscriptions
More information about the foundations-bugs
mailing list