[Bug 1680599] Re: unattended-upgrades crashes without writing to the log on invalid config file entries

[Patrik Karisch]

Ok, that's a strange behavior. As long as there are no pending updates,
it's fine.

When there is an update available it errors:

Traceback (most recent call last):
  File "/usr/bin/unattended-upgrades", line 1473, in <module>
    main(options)
  File "/usr/bin/unattended-upgrades", line 1198, in main
    allowed_origins=allowed_origins)
  File "/usr/bin/unattended-upgrades", line 105, in __init__
    self.adjust_candidate_versions()
  File "/usr/bin/unattended-upgrades", line 126, in adjust_candidate_versions
    if is_allowed_origin(pkg.candidate, self.allowed_origins):
  File "/usr/bin/unattended-upgrades", line 512, in is_allowed_origin
    if match_whitelist_string(allowed, origin):
  File "/usr/bin/unattended-upgrades", line 363, in match_whitelist_string
    for s in token.split("=")]
ValueError: not enough values to unpack (expected 2, got 1)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1680599

Title:
  unattended-upgrades crashes without writing to the log on invalid
  config file entries

Status in unattended-upgrades package in Ubuntu:
  Confirmed

Bug description:
  If Unattended-Upgrade::Allowed-Origins in 50unattended-upgrades
  contains an invalid entry, such as "invalid", unattended-upgrades
  crashes without writing to /var/log/unattended-upgrades/unattended-
  upgrades.log.

  # unattended-upgrades --debug
  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrades", line 1536, in <module>
      main(options)
    File "/usr/bin/unattended-upgrades", line 1202, in main
      allowed_origins = get_allowed_origins()
    File "/usr/bin/unattended-upgrades", line 343, in get_allowed_origins
      allowed_origins = get_allowed_origins_legacy()
    File "/usr/bin/unattended-upgrades", line 328, in get_allowed_origins_legacy
      (distro_id, distro_codename) = s.split()
  ValueError: not enough values to unpack (expected 2, got 1)

  0.92ubuntu1.2 on 16.10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1680599/+subscriptions