[Bug 1675163] Re: Don't attempt to create devices in LXC containers

[Stéphane Graber]

root at zesty:~# apt install makedev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following NEW packages will be installed:
  makedev
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 24.4 kB of archives.
After this operation, 98.3 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu zesty/universe amd64 makedev all 2.3.1-93ubuntu2 [24.4 kB]
Fetched 24.4 kB in 0s (81.9 kB/s)  
Selecting previously unselected package makedev.
(Reading database ... 26514 files and directories currently installed.)
Preparing to unpack .../makedev_2.3.1-93ubuntu2_all.deb ...
Unpacking makedev (2.3.1-93ubuntu2) ...
Setting up makedev (2.3.1-93ubuntu2) ...
LXC container detected, aborting due to LXC managed /dev.
Processing triggers for man-db (2.7.6.1-2) ...
root at zesty:~# 

** Changed in: makedev (Ubuntu Yakkety)
       Status: Triaged => In Progress

** Changed in: makedev (Ubuntu Trusty)
       Status: Triaged => In Progress

** Changed in: makedev (Ubuntu Xenial)
       Status: Triaged => In Progress

** Changed in: makedev (Ubuntu Precise)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to makedev in Ubuntu.
https://bugs.launchpad.net/bugs/1675163

Title:
  Don't attempt to create devices in LXC containers

Status in makedev package in Ubuntu:
  Fix Released
Status in makedev source package in Precise:
  In Progress
Status in makedev source package in Trusty:
  In Progress
Status in makedev source package in Xenial:
  In Progress
Status in makedev source package in Yakkety:
  In Progress
Status in makedev source package in Zesty:
  Fix Released

Bug description:
  Right now the "makedev" postinst script will attempt to create a
  number of devices in /dev, failing the package upgrade should any of
  those mknod calls fail.

  LXC containers, especially unprivileged ones do not allow the use of
  mknod, making it impossible to upgrade makedev in those containers and
  preventing Ubuntu release upgrades.

  The fix is quite simple, detect that we are running in an LXC
  container and skip the rest of the postinst script as is done in a
  number of other cases.

  = SRU
  == Rationale
  This issue prevents release to release upgrades in unprivileged LXC containers when makedev is part of the upgraded set. This is currently visible when upgrading from Ubuntu 12.04 to Ubuntu 14.04.

  == Testcase
  Install the new package in an unprivileged container. With LXD, simply use "lxc launch ubuntu:<series> test" to create the container.

  Prior to this fix, the upgrade will fail on some mknod errors, after
  it, it'll go on after printing a message indicating that LXC was
  detected.

  == Regression potential
  The detection logic is based on PID 1's environment containing a container=lxc entry. If a non-LXC system somehow had that set, it'd lead to the makedev upgrade no longer creating extra devices. This is unlikely to really matter though since the system is clearly already functioning properly at that point.

  Similarly, some privileged LXC containers can be configured in a way
  where mknod is possible, this update will still disable the postinst
  for those cases as short of attempting every mknod ahead of time,
  there is no reliable way to detect any seccomp or apparmor policy in
  play.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/makedev/+bug/1675163/+subscriptions