[Bug 1686803] Re: sudo returns exit code 0 if child is killed with SIGTERM

[Balint Reczey]

** Description changed:

+ [Impact]
+ 
+  * sudo returns exit code 0 if child is killed with signals other than SIGINT
+  * This can break scripts assuming successful execution of the command ran by
+    sudo
+ 
+ [Test Case]
+ 
+  * Open two separate shells
+    1. In shell 1. run:
+      ubuntu at tough-calf:~$ sudo sleep 300; echo $?
+    2. In shell 2. run:
+      root at tough-calf:~# killall -TERM sleep
+    3. In broken versions shell 1. shows this:
+      ubuntu at tough-calf:~$ sudo sleep 300; echo $?
+      0
+ 
+    4. Install fixed version
+    5. Execute steps 1. and 2.
+    6. In fixed version shell 1. shows this:
+      ubuntu at tough-calf:~$ sudo sleep 300; echo $?
+      Terminated
+      143
+ 
+ [Regression Potential]
+ 
+  *  sudo may exit with a different status than expected
+ 
+ [Other Info]
+ 
+ original bug description:
+ 
  Please backport upstream sudo changeset 10917:50b988d0c97f "The fix for
  Bug #722 contained a typo/thinko that resulted in the" to xenial,
  yakkety, and zesty versions of sudo.
  
  This will fix a regression documented by this upstream bug report:
  https://bugzilla.sudo.ws/show_bug.cgi?id=784
  
  sudo 1.8.15 changeset 10229:153f016db8f1 "When the command sudo is
  running is killed by a signal, sudo will" introduced a regression where
  the exit status is always 0 when a command is killed by a signal other
  than SIGINT. https://www.sudo.ws/repos/sudo/rev/153f016db8f1
  
  This will be fixed in sudo 1.8.20 with changeset 10917:50b988d0c97f "The
  fix for Bug #722 contained a typo/thinko that resulted in the".
  https://www.sudo.ws/repos/sudo/rev/50b988d0c97f
  
  trusty sudo is based off sudo 1.8.9 and is not affected. xenial sudo
  based off sudo 1.8.16, yaketty sudo based off sudo 1.8.16, and zesty
  sudo based off 1.8.19 need the fix.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to sudo in Ubuntu.
https://bugs.launchpad.net/bugs/1686803

Title:
  sudo returns exit code 0 if child is killed with SIGTERM

Status in sudo:
  Unknown
Status in sudo package in Ubuntu:
  Triaged
Status in sudo source package in Artful:
  Triaged

Bug description:
  [Impact]

   * sudo returns exit code 0 if child is killed with signals other than SIGINT
   * This can break scripts assuming successful execution of the command ran by
     sudo

  [Test Case]

   * Open two separate shells
     1. In shell 1. run:
       ubuntu at tough-calf:~$ sudo sleep 300; echo $?
     2. In shell 2. run:
       root at tough-calf:~# killall -TERM sleep
     3. In broken versions shell 1. shows this:
       ubuntu at tough-calf:~$ sudo sleep 300; echo $?
       0

     4. Install fixed version
     5. Execute steps 1. and 2.
     6. In fixed version shell 1. shows this:
       ubuntu at tough-calf:~$ sudo sleep 300; echo $?
       Terminated
       143

  [Regression Potential]

   *  sudo may exit with a different status than expected

  [Other Info]

  original bug description:

  Please backport upstream sudo changeset 10917:50b988d0c97f "The fix
  for Bug #722 contained a typo/thinko that resulted in the" to xenial,
  yakkety, and zesty versions of sudo.

  This will fix a regression documented by this upstream bug report:
  https://bugzilla.sudo.ws/show_bug.cgi?id=784

  sudo 1.8.15 changeset 10229:153f016db8f1 "When the command sudo is
  running is killed by a signal, sudo will" introduced a regression
  where the exit status is always 0 when a command is killed by a signal
  other than SIGINT. https://www.sudo.ws/repos/sudo/rev/153f016db8f1

  This will be fixed in sudo 1.8.20 with changeset 10917:50b988d0c97f
  "The fix for Bug #722 contained a typo/thinko that resulted in the".
  https://www.sudo.ws/repos/sudo/rev/50b988d0c97f

  trusty sudo is based off sudo 1.8.9 and is not affected. xenial sudo
  based off sudo 1.8.16, yaketty sudo based off sudo 1.8.16, and zesty
  sudo based off 1.8.19 need the fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/sudo/+bug/1686803/+subscriptions