[Bug 1671019] Re: PowerNV: Restart opal-prd daemon on any kind of failure

[Launchpad Bug Tracker]

This bug was fixed in the package skiboot - 5.3.3-1ubuntu0.1

---------------
skiboot (5.3.3-1ubuntu0.1) yakkety; urgency=medium

  * debian/opal-prd.service: set Restart=always, which is the correct policy
    for this hardware-related service in the unlikely event of crashes.
    LP: #1671019.

 -- Steve Langasek <steve.langasek at ubuntu.com>  Sat, 10 Jun 2017
13:06:37 -0700

** Changed in: skiboot (Ubuntu Yakkety)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to skiboot in Ubuntu.
Matching subscriptions: foundations-bugs-skiboot
https://bugs.launchpad.net/bugs/1671019

Title:
  PowerNV: Restart opal-prd daemon on any kind of failure

Status in The Ubuntu-power-systems project:
  Fix Released
Status in skiboot package in Ubuntu:
  Fix Released
Status in skiboot source package in Xenial:
  Fix Released
Status in skiboot source package in Yakkety:
  Fix Released
Status in skiboot source package in Zesty:
  Fix Released

Bug description:
  [SRU Justification]
  As a hardware diagnostic service, it's important that opal-prd be kept running even in the face of hardware unreliability.  The most effective way to do this is with a systemd unit policy of Restart=always, to ensure the service is not allowed to accidentally die.

  [Test case]
  1. Install the opal-prd package on a system that has /dev/mtd0.
  2. Verify that the service is running with 'systemctl status opal-prd'.
  3. Get the pid of the opal-prd process from systemctl and kill it with 'sudo kill -9 $pid'.
  4. Verify via 'systemctl status opal-prd' that the service is no longer running.
  5. Install opal-prd from -proposed.
  6. Verify via 'systemctl status opal-prd' that the service is running again.
  7. Kill the new process with 'sudo kill -9 $pid'.
  8. Verify via 'systemctl status opal-prd' that the service has been restarted.
  9. Install the opal-prd package from -proposed on a system that does not have /dev/mtd0.
  10. Verify that 'systemctl status opal-prd' shows the service is inactive, and has not been allowed to restart indefinitely after failure, driving up the system load.

  [Regression potential]
  Since the package may be installed on systems where opal-prd is useless and will not run, it's important to verify for each release that Restart=always doesn't cause systemd to go into a busy loop trying to restart the service under these conditions.  The uploaded change should guard against this by checking for the correct path before starting the job, and the test case should further confirm this.

  
  == Comment: #0 - VASANT HEGDE <hegdevasant at in.ibm.com> - 2017-03-08 03:12:33 ==
  ---Problem Description---
  opal-prd package contains prd daemon (Processor Runtime Diagnostics).

  One of the requirements from a field service perspective is to be able
  to restart opal-prd when it fails for whatever reason.

  Direct systemd to restart the opal-prd service on any kind of failure.

  Ubuntu contains opal-prd package.  This bug is to restart daemon after
  failure

  Contact Information = hegdevasant at linux.vnet.ibm.com

  Machine Type = All Open Power Systems

  Userspace tool common name: opal-prd

  Userspace rpm: opal-prd

  The userspace tool has the following bit modes: 64bit

  == Comment: #3 - Ananth Narayan M G <ananth.narayan at in.ibm.com> - 2017-03-08 03:37:46 ==
  Posted patch upstream for this -- https://lists.ozlabs.org/pipermail/skiboot/2017-March/006612.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1671019/+subscriptions