[Bug 1704677] Re: 229-4ubuntu18: '+' command prefix does not work in ExecStart*= and ExecStop*=

[linuxball]

I tested the proposed package (systemd 229-4ubuntu19) in my xenial
system (see above apport info) and I can confirm that the committed fix
works.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1704677

Title:
  229-4ubuntu18: '+' command prefix does not work in ExecStart*= and
  ExecStop*=

Status in systemd package in Ubuntu:
  Invalid
Status in systemd source package in Xenial:
  Fix Committed

Bug description:
  [Impact]
  229-4ubuntu18 included changes irrelevant for xenial, which whilst harmless generates a lot of scary journal entries.

  [Fix]
  Drop the cherrypciked ExecStart|StopPost stanzas from the drop in snippet. Integration of the resolved stub resolver with resolvconf on xenial is not required, because resolved in xenial does not have stub resolver. Also xenial's systemd does not support '+' prefix on the Exec* lines.

  [Testcase]
  Upgrade to te new SRU, make sure testcase from https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1673860 still passes

  Check that there is no extra journal warnings/errors about "Executable
  path is not absolute" from systemd reading /lib/systemd/system
  /systemd-resolved.service.d/resolvconf.con

  [Original Descrption]

  
  The systemd version 229-4ubuntu18 from xenial-proposed archive has a bug. The '+' prefix (see https://www.freedesktop.org/software/systemd/man/systemd.service.html) in ExecStart*= and ExecStop*= statements does not work any longer.

  File /lib/systemd/system/systemd-resolved.service.d/resolvconf.conf of
  this version contains two commands prefixed with '+':

  # When resolved is in use, it must be brought up before we consider networking
  # available because otherwise there is a window where DNS resolution doesn't
  # work.
  [Unit]
  Before=network-online.target

  # tell resolvconf about resolved's builtin DNS server, so that DNS servers
  # picked up via networkd are respected when using resolvconf, and that software
  # like Chrome that does not do NSS (libnss-resolve) still gets proper DNS
  # resolution
  [Service]
  ExecStartPost=+/bin/sh -c '[ ! -e /run/resolvconf/enable-updates ] || echo "nameserver 127.0.0.53" | /sbin/resolvconf -a systemd-resolved'
  ExecStopPost=+/bin/sh -c '[ ! -e /run/resolvconf/enable-updates ] || /sbin/resolvconf -d systemd-resolved'

  Those two statements in section [Service] lead to the following two
  error messages in dmesg:

  [    3.687475] systemd[1]: [/lib/systemd/system/systemd-resolved.service.d/resolvconf.conf:12] Executable path is not absolute, ignoring: +/bin/sh -c '[ ! -e /run/resolvconf/enable-updates ] || echo "nameserver 127.0.0.53" | /sbin/resolvconf -a systemd-resolved'
  [    3.687614] systemd[1]: [/lib/systemd/system/systemd-resolved.service.d/resolvconf.conf:13] Executable path is not absolute, ignoring: +/bin/sh -c '[ ! -e /run/resolvconf/enable-updates ] || /sbin/resolvconf -d systemd-resolved'
  ---
  ApportVersion: 2.20.1-0ubuntu2.9
  Architecture: amd64
  CurrentDesktop: LXDE
  DistroRelease: Ubuntu 16.04
  MachineType: LENOVO 42406AG
  Package: systemd 229-4ubuntu18
  PackageArchitecture: amd64
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.4.0-85-lowlatency root=UUID=1756e76f-2b6c-479f-8ea3-e3b087b1922f ro quiet apparmor=0
  ProcVersionSignature: Ubuntu 4.4.0-85.108-lowlatency 4.4.73
  Tags: xenial package-from-proposed third-party-packages
  Uname: Linux 4.4.0-85-lowlatency x86_64
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm audio cdrom colord davfs2 dialout dip fax floppy libvirtd lpadmin netdev plugdev saned scanner sudo tape video wireshark
  _MarkForUpload: True
  dmi.bios.date: 09/20/2016
  dmi.bios.vendor: LENOVO
  dmi.bios.version: 8AET66WW (1.46 )
  dmi.board.asset.tag: Not Available
  dmi.board.name: 42406AG
  dmi.board.vendor: LENOVO
  dmi.board.version: Not Available
  dmi.chassis.asset.tag: No Asset Information
  dmi.chassis.type: 10
  dmi.chassis.vendor: LENOVO
  dmi.chassis.version: Not Available
  dmi.modalias: dmi:bvnLENOVO:bvr8AET66WW(1.46):bd09/20/2016:svnLENOVO:pn42406AG:pvrThinkPadT520:rvnLENOVO:rn42406AG:rvrNotAvailable:cvnLENOVO:ct10:cvrNotAvailable:
  dmi.product.name: 42406AG
  dmi.product.version: ThinkPad T520
  dmi.sys.vendor: LENOVO
  mtime.conffile..etc.pam.d.systemd-user: 2017-03-09T13:47:30.332992

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1704677/+subscriptions