[Bug 1692420] Comment bridged from LTC Bugzilla

[bugproxy]

------- Comment From pavrampu at in.ibm.com 2017-12-21 00:16 EDT-------
(In reply to comment #51)
> I think the upstream patch for lsdevinfo is incomplete as there is another
> call to cat. From the code:
>
> 254         # get the physical location
> 255         physloc=$($CAT $dev/ibm,loc-code)
> 256         type="$($OD -t x2 $dev/vendor-id $dev/device-id |
> 257                 $CUT -f3,5 -d ' ' -s --output-delimiter='')"
>
> Do the other commands that were problematic (ls-vscsi, ls-veth, and
> ofpathname) work?

Issue is observed even with other commands.

:~# ls-vscsi
/usr/sbin/ls-vscsi: line 72: warning: command substitution: ignored null byte in input
host0 U8286.42A.1069B3T-V8-C17-T1
~#  ls-veth
/usr/sbin/ls-veth: line 74: warning: command substitution: ignored null byte in input
ibmveth2 U8286.42A.1069B3T-V8-C2-T1
:~# ofpathname /dev/sda
/usr/sbin/ofpathname: line 812: warning: command substitution: ignored null byte in input
/usr/sbin/ofpathname: line 865: cd: too many arguments
/vdevice/v-scsi at 30000011/disk at 8100000000000000

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to powerpc-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1692420

Title:
  [SRU] powerpc-utils commands exhibits "command substitution: ignored
  null byte in input" warning message

Status in The Ubuntu-power-systems project:
  Fix Committed
Status in powerpc-utils package in Ubuntu:
  Fix Released
Status in powerpc-utils source package in Zesty:
  Fix Committed

Bug description:
  [Impact]

  The current version of powerpc-utils in Ubuntu Zesty and Artful
  carries a bug exposed by bash 4.4+ which causes a warning to be logged
  to stderr in 4 different commands: ls-veth, ls-vscsi, lsdevinfo, and
  ofpathname. Bash is unable to store the NUL bytes in the result of a
  command substitution, prior to 4.4 it silently dropped the NUL bytes,
  but since 4.4 it drops the NUL bytes with a warning: "command
  substitution: ignored null byte in input".

  Additionally to that the ofpathname command also had a bug that caused
  a "cd: too many arguments" warning.

  Upstream has fixed both [1] and they now need to be backport to Zesty.

  [Test Case 1]

  Call any of the affected commands without arguments, they should
  output "command substitution: ignored null byte in input" to stderr.

  The same warning can easily be reproduced in bash 4.4+ by executing:
  $ x=$(cat < /proc/$$/cmdline)
  bash: warning: command substitution: ignored null byte in input

  And to fix it:
  $ x=$(tr -d '\0' < /proc/$$/cmdline)
  <no output, as expected>

  [Test Case 2]
  Call ofpathname with no arguments:
  $ ofpathname
  cd: too many arguments

  [Regression Potential]

  The replacement of 'cat' with 'tr -d "\0"' causes no regression. Also,
  both commands are part of coreutils.

  The 'cd' fix replaces it with a drop_dir call. In case the requested
  path is not found then the previous behavior would be kept (ie. no
  directory change).

  [Other Info]

  Upstream fix link:
  [1] https://github.com/ibm-power-utilities/powerpc-utils/commit/4fcc611a09caea70e6bca6a1275211c72ac4bb45

  [Old description]
  Please cherry pick...

  https://github.com/ibm-power-utilities/powerpc-
  utils/commit/4fcc611a09caea70e6bca6a1275211c72ac4bb45

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1692420/+subscriptions