[Bug 1703365] Re: /usr/bin/update-manager:AttributeError:<lambda>:on_settings_button_clicked:show_settings

[Jean-Baptiste Lallement]

** Description changed:

- Test Case:
+ [Impact] 
+ Update Manager passes it's window Id to software-properties by calling get_xid() which does not exist under wayland and results in this crash. This patch does not add --toplevel under wayland to work around this crash.
+ 
+ [Test Case]
+ Test Steps
  1. Launch update-manager and wait until the main UI is displayed (after sources are refreshed)
  2. Click on "Settings..."
  
  Expected result
  The Settings dialog is displayed
  
  Actual result
  It is not displayed and this crash occurs
- Traceback (most recent call last):             
-   File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 112, in <lambda>        
-     button.connect("clicked", lambda x: callback())                                            
-   File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 127, in on_settings_button_clicked                                                                                     
-     self.window_main.show_settings()           
-   File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 196, in show_settings                                                                                            
-     "--toplevel", "%s" % self.get_window().get_xid()                                           
- AttributeError: 'GdkWaylandWindow' object has no attribute 'get_xid' 
+ Traceback (most recent call last):
+   File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 112, in <lambda>
+     button.connect("clicked", lambda x: callback())
+   File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 127, in on_settings_button_clicked
+     self.window_main.show_settings()
+   File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 196, in show_settings
+     "--toplevel", "%s" % self.get_window().get_xid()
+ AttributeError: 'GdkWaylandWindow' object has no attribute 'get_xid'
  
+ [Regression Potential]
+ Very low. The option --toplevel is excluded only for wayland and added for any other display server. So for other display server than wayland the behaviour is unchanged.
  
  The Ubuntu Error Tracker has been receiving reports about a problem regarding update-manager.  This problem was most recently seen with package version 1:17.04.3, the problem page at https://errors.ubuntu.com/problem/12e7e8364ae0ad1fe84dc3972adbc9506d7e2f71 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker you can request it at http://forms.canonical.com/reports/.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1703365

Title:
  /usr/bin/update-
  manager:AttributeError:<lambda>:on_settings_button_clicked:show_settings

Status in update-manager package in Ubuntu:
  Fix Released
Status in update-manager source package in Zesty:
  Confirmed

Bug description:
  [Impact] 
  Update Manager passes it's window Id to software-properties by calling get_xid() which does not exist under wayland and results in this crash. This patch does not add --toplevel under wayland to work around this crash.

  [Test Case]
  Test Steps
  1. Launch update-manager and wait until the main UI is displayed (after sources are refreshed)
  2. Click on "Settings..."

  Expected result
  The Settings dialog is displayed

  Actual result
  It is not displayed and this crash occurs
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 112, in <lambda>
      button.connect("clicked", lambda x: callback())
    File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 127, in on_settings_button_clicked
      self.window_main.show_settings()
    File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 196, in show_settings
      "--toplevel", "%s" % self.get_window().get_xid()
  AttributeError: 'GdkWaylandWindow' object has no attribute 'get_xid'

  [Regression Potential]
  Very low. The option --toplevel is excluded only for wayland and added for any other display server. So for other display server than wayland the behaviour is unchanged.

  The Ubuntu Error Tracker has been receiving reports about a problem regarding update-manager.  This problem was most recently seen with package version 1:17.04.3, the problem page at https://errors.ubuntu.com/problem/12e7e8364ae0ad1fe84dc3972adbc9506d7e2f71 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker you can request it at http://forms.canonical.com/reports/.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/1703365/+subscriptions