[Bug 1684341] [NEW] EFI fallback binary should only be installed in force-extra-removable

[Mathieu Trudel-Lapierre]

Public bug reported:

The patch I did to fix names for the new naming of shim binaries
included the addition of fbx64.efi; but it was done wrong: fbx64.efi
should only exist under \EFI\BOOT, it's not required in the "removable"
path; except if we're trying to force installing to the removable path
*too*.

In other words:
1) we normally don't want /EFI/ubuntu/fbx64.efi to exist;

and 
a) on a desktop or server, we want /EFI/BOOT/fbx64.efi to exist (ie. installs without --removable, and with --force-extra-removable used when grub-install was called);
b) on removable media, we do not want /EFI/BOOT/fbx64.efi to exist (ie. when grub-installed is called with --removable).

Furthermore, the (a) case is probably not the typical case we want to
run grub-install with. Calls to grub-install with --force-extra-
removable probably should be limited to shim-signed's postinst.

In any case, let's move the fbx64.efi installation step to
also_install_removable() in grub-installer to avoid installing it when
it shouldn't be.

** Affects: grub2 (Ubuntu)
     Importance: Critical
     Assignee: Mathieu Trudel-Lapierre (cyphermox)
         Status: In Progress

** Affects: grub2 (Ubuntu Trusty)
     Importance: Undecided
         Status: New

** Affects: grub2 (Ubuntu Xenial)
     Importance: Undecided
         Status: New

** Affects: grub2 (Ubuntu Yakkety)
     Importance: Undecided
         Status: New

** Affects: grub2 (Ubuntu Zesty)
     Importance: Critical
     Assignee: Mathieu Trudel-Lapierre (cyphermox)
         Status: In Progress

** Summary changed:

- EFI fallback binary should only be installed in removable path
+ EFI fallback binary should only be installed in force-extra-removable

** Changed in: grub2 (Ubuntu)
       Status: New => Triaged

** Changed in: grub2 (Ubuntu)
   Importance: Undecided => Critical

** Changed in: grub2 (Ubuntu)
       Status: Triaged => In Progress

** Changed in: grub2 (Ubuntu)
     Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

** Changed in: grub2 (Ubuntu)
    Milestone: None => ubuntu-17.05

** Also affects: grub2 (Ubuntu Zesty)
   Importance: Critical
     Assignee: Mathieu Trudel-Lapierre (cyphermox)
       Status: In Progress

** Also affects: grub2 (Ubuntu Trusty)
   Importance: Undecided
       Status: New

** Also affects: grub2 (Ubuntu Yakkety)
   Importance: Undecided
       Status: New

** Also affects: grub2 (Ubuntu Xenial)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1684341

Title:
  EFI fallback binary should only be installed in force-extra-removable

Status in grub2 package in Ubuntu:
  In Progress
Status in grub2 source package in Trusty:
  New
Status in grub2 source package in Xenial:
  New
Status in grub2 source package in Yakkety:
  New
Status in grub2 source package in Zesty:
  In Progress

Bug description:
  The patch I did to fix names for the new naming of shim binaries
  included the addition of fbx64.efi; but it was done wrong: fbx64.efi
  should only exist under \EFI\BOOT, it's not required in the
  "removable" path; except if we're trying to force installing to the
  removable path *too*.

  In other words:
  1) we normally don't want /EFI/ubuntu/fbx64.efi to exist;

  and 
  a) on a desktop or server, we want /EFI/BOOT/fbx64.efi to exist (ie. installs without --removable, and with --force-extra-removable used when grub-install was called);
  b) on removable media, we do not want /EFI/BOOT/fbx64.efi to exist (ie. when grub-installed is called with --removable).

  Furthermore, the (a) case is probably not the typical case we want to
  run grub-install with. Calls to grub-install with --force-extra-
  removable probably should be limited to shim-signed's postinst.

  In any case, let's move the fbx64.efi installation step to
  also_install_removable() in grub-installer to avoid installing it when
  it shouldn't be.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1684341/+subscriptions