[Bug 1679867] [NEW] init-functions.d/40-systemd bug

[Paweł Ufnalewski]

Public bug reported:

When I install ntp package it won't start with /etc/init.d/ntp start.
Going inside the scripts and includes I've found, that ntp init script
is including /lib/lsb/init-functions which then includes files in
/lib/lsb/init-functions.d/ folder. Content of my folder is:

ls -lah /lib/lsb/init-functions.d/
total 28K
drwxr-xr-x 2 root root 4.0K Feb 15 15:06 .
drwxr-xr-x 3 root root 4.0K Feb 15 15:01 ..
-rw-r--r-- 1 root root  965 Jan 10  2016 01-upstart-lsb
-rw-r--r-- 1 root root 1.1K Aug 29  2014 20-left-info-blocks
-rw-r--r-- 1 root root 2.6K Jan 13 11:30 40-systemd
-rw-r--r-- 1 root root 3.4K May 27  2014 50-ubuntu-logging
-rw-r--r-- 1 root root  515 May 10  2016 99-plymouth

when files are loaded one by one, whole init script crashes, beause
there's wrong command used at the end of the script:


if [ "$_use_systemctl" = "1" ]; then
    # Some init scripts use "set -e" and "set -u", we don't want that
    # here
    set +e
    set +u

    if  [ "x$1" = xstart -o \
        "x$1" = xstop -o \
        "x$1" = xrestart -o \
        "x$1" = xreload -o \
        "x$1" = xforce-reload -o \
        "x$1" = xstatus ] ; then

        systemctl_redirect $0 $1
        exit $?
    fi
fi

it should be return $0. After change, it works ok.

Tested on clean install of Ubuntu 16.04 with backports. All packages
updated.

** Affects: systemd (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1679867

Title:
  init-functions.d/40-systemd bug

Status in systemd package in Ubuntu:
  New

Bug description:
  When I install ntp package it won't start with /etc/init.d/ntp start.
  Going inside the scripts and includes I've found, that ntp init script
  is including /lib/lsb/init-functions which then includes files in
  /lib/lsb/init-functions.d/ folder. Content of my folder is:

  ls -lah /lib/lsb/init-functions.d/
  total 28K
  drwxr-xr-x 2 root root 4.0K Feb 15 15:06 .
  drwxr-xr-x 3 root root 4.0K Feb 15 15:01 ..
  -rw-r--r-- 1 root root  965 Jan 10  2016 01-upstart-lsb
  -rw-r--r-- 1 root root 1.1K Aug 29  2014 20-left-info-blocks
  -rw-r--r-- 1 root root 2.6K Jan 13 11:30 40-systemd
  -rw-r--r-- 1 root root 3.4K May 27  2014 50-ubuntu-logging
  -rw-r--r-- 1 root root  515 May 10  2016 99-plymouth

  when files are loaded one by one, whole init script crashes, beause
  there's wrong command used at the end of the script:

  
  if [ "$_use_systemctl" = "1" ]; then
      # Some init scripts use "set -e" and "set -u", we don't want that
      # here
      set +e
      set +u

      if  [ "x$1" = xstart -o \
          "x$1" = xstop -o \
          "x$1" = xrestart -o \
          "x$1" = xreload -o \
          "x$1" = xforce-reload -o \
          "x$1" = xstatus ] ; then

          systemctl_redirect $0 $1
          exit $?
      fi
  fi

  it should be return $0. After change, it works ok.

  Tested on clean install of Ubuntu 16.04 with backports. All packages
  updated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1679867/+subscriptions