[Bug 1446537] Re: apport hook fails in add_info with TypeError: 'str' does not support the buffer interface

[Brian Murray]

I utilized the version of the package from -proposed and did not receive
a crash.

 $ PYTHONPATH='' ubuntu-bug ubiquity 
/usr/share/apport/apport-gtk:16: PyGIWarning: Wnck was imported without specifying a version first. Use gi.require_version('Wnck', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import GLib, Wnck, GdkX11, Gdk
dpkg-query: no packages found matching ubiquity

 $ apt-cache policy apport
apport:
  Installed: 2.20.1-0ubuntu2.2
  Candidate: 2.20.1-0ubuntu2.2
  Version table:
 *** 2.20.1-0ubuntu2.2 500
        500 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu xenial-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     2.20.1-0ubuntu2.1 500
        500 http://192.168.10.7/ubuntu xenial-updates/main amd64 Packages
        500 http://192.168.10.7/ubuntu xenial-updates/main i386 Packages
     2.20.1-0ubuntu2 500
        500 http://192.168.10.7/ubuntu xenial/main amd64 Packages
        500 http://192.168.10.7/ubuntu xenial/main i386 Packages


** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1446537

Title:
  apport hook fails in add_info with TypeError: 'str' does not support
  the buffer interface

Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Xenial:
  Fix Committed

Bug description:
  Impact
  ------
  Some apport package hooks are not able to check the contents of log files for errors, e.g. looking for hard disk errors in ubiquity install logs, so we may be getting crash reports that we don't want.

  
  Test Case
  ---------
  ⟫ ubuntu-bug ubiquity
  dpkg-query: aucun paquet ne correspond à ubiquity
  ERROR: hook /usr/share/apport/package-hooks/source_ubiquity.py crashed:
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/apport/report.py", line 197, in _run_hook
      symb['add_info'](report, ui)
    File "/usr/share/apport/package-hooks/source_ubiquity.py", line 61, in add_info
      if 'Buffer I/O error on device' in syslog:
  TypeError: 'str' does not support the buffer interface

  With the version of the package in the archive you'll see the above
  Traceback, with the version of proposed you will not.

  Regression Potential
  --------------------
  The change uses a try, except clause to do the decoding of the log file so there should be little chance of a regression.

  
  ProblemType: BugDistroRelease: Ubuntu 15.04
  Package: ubiquity (not installed)
  ProcVersionSignature: Ubuntu 3.19.0-14.14-generic 3.19.3
  Uname: Linux 3.19.0-14-generic x86_64
  ApportVersion: 2.17.2-0ubuntu1
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Tue Apr 21 10:15:56 2015
  InstallationDate: Installed on 2013-09-03 (594 days ago)
  InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130902)SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1446537/+subscriptions