[Bug 1579949] Re: add_gdb_info hides OSErrors when running gdb during retracing

[Martin Pitt]

** Also affects: apport (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: apport (Ubuntu)
       Status: New => Fix Committed

** Changed in: apport (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1579949

Title:
  add_gdb_info hides OSErrors when running gdb during retracing

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Committed

Bug description:
  I've been trying to debug an issue with apport trunk and retracing
  crashes from Xenial.  Come to find out I was receiving an OSError when
  running gdb (see bug 1579897) but didn't know it because of this code
  in report.py's add_gdb_info.

   721         # call gdb
   722         try:
   723             out = _command_output(gdb_cmd).decode('UTF-8', errors='replace')
   724         except OSError:
   725             return

  If _command_output tries to raise an OSError, it seems to me like we
  shouldn't just return in line 725.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1579949/+subscriptions