[Bug 1432062] Re: multipath-tools-boot: support booting without user_friendly_names on devices with spaces in identifiers

[Mauricio Faria de Oliveira]

Test with multipath device:
==========================

# multipath
create: 0QEMU    QEMU HARDDISK   test undef QEMU    ,QEMU HARDDISK   
size=2.0G features='0' hwhandler='0' wp=undef
`-+- policy='round-robin 0' prio=1 status=undef
  `- 0:0:1:0 sdb 8:16 undef ready running

# ls -l /dev/mapper/
total 0
brw-rw---- 1 root disk 252,   1 Jan  7 10:31 0QEMU    QEMU HARDDISK   test
lrwxrwxrwx 1 root root        7 Jan  7 10:31 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test -> ../dm-1
crw------- 1 root root  10, 236 Jan  7 09:00 control

Without patch:
-------------

# kpartx -av '/dev/mapper/0QEMU    QEMU HARDDISK   test'
device-mapper: reload ioctl on 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test1 failed: Invalid argument
create/reload failed on 0QEMU    QEMU HARDDISK   test1
add map 0QEMU    QEMU HARDDISK   test1 (0:0): 0 4194242 linear /dev/mapper/0QEMU    QEMU HARDDISK   test 62

# ls -l /dev/mapper
total 0
brw-rw---- 1 root disk 252,   1 Jan  7 10:31 0QEMU    QEMU HARDDISK   test
lrwxrwxrwx 1 root root        7 Jan  7 10:31 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test -> ../dm-1
crw------- 1 root root  10, 236 Jan  7 09:00 control

With patch:
----------

# kpartx -av '/dev/mapper/0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test'
add map 0QEMU    QEMU HARDDISK   test1 (252:5): 0 4194242 linear /dev/mapper/0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test 62

# ls -l /dev/mapper/
total 0
brw-rw---- 1 root disk 252,   1 Jan  7 10:31 0QEMU    QEMU HARDDISK   test
lrwxrwxrwx 1 root root        7 Jan  7 10:31 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test -> ../dm-1
brw-rw---- 1 root disk 252,   5 Jan  7 10:32 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test1
crw------- 1 root root  10, 236 Jan  7 09:00 control

# kpartx -dv '/dev/mapper/0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test'
del devmap : 0QEMU    QEMU HARDDISK   test1

# ls -l /dev/mapper/
total 0
brw-rw---- 1 root disk 252,   1 Jan  7 10:31 0QEMU    QEMU HARDDISK   test
lrwxrwxrwx 1 root root        7 Jan  7 10:31 0QEMU\x20\x20\x20\x20QEMU\x20HARDDISK\x20\x20\x20test -> ../dm-1
crw------- 1 root root  10, 236 Jan  7 09:00 control

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to multipath-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1432062

Title:
  multipath-tools-boot: support booting without user_friendly_names on
  devices with spaces in identifiers

Status in multipath-tools package in Ubuntu:
  Confirmed

Bug description:
  If a system is not installed w/ multipath support (i.e., no disk-detect/multipath/enable=true), the /etc/multipath.conf file is not installed.
  If an user later installs multipath-tools-boot, it will enable the udev rules for multipath support.
  Those rules don't handle disk devices w/ spaces on their names/uuids/models very well..

  That's because of udev's SYMLINK command using spaces to separate
  multiple links, and the kernel sysfs/dm informing \x20 instead, which
  is not correctly interpreted by some commands, resulting in file not
  found errors, for example.

  Thus, the system fails to boot.

  There's no problem, however, if user_friendly_names is enabled in
  multipath.conf (which is enabled in the default multipath.conf from
  the installer, if it has multipath enabled).

  Notice it's an acceptable case to install w/out multipath support, and
  enable it later for booting.

  Disk devices w/ spaces in naming is not common over SAN/storage systems, but that happens often for conventional disks; for example:
  - IBM IPR  ( IBM     IPR-0   5DB6F40000000080 )
  - IBM VDASD ( AIX     VDASD           00c96f0700004c000000014bb8e713f0.14 )
  - QEMU HARDDISK ( QEMU QEMU HARDDISK <serial> )

  So, please, is it possible to ship the default multipath.conf (e.g.,
  from installer) w/ multipath-tools-boot?

  For users not to their systems failing to boot after installing
  multipath-tools-boot manually, after a non-multipath install.

  Related bugs:
   * bug 1371634: block devices appear twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1432062/+subscriptions