[Bug 1459872] Re: using progress mod w/ net files crashes
Launchpad Bug Tracker
1459872 at bugs.launchpad.net
Tue Jan 5 17:55:42 UTC 2016
This bug was fixed in the package grub2 - 2.02~beta2-22ubuntu1.5
---------------
grub2 (2.02~beta2-22ubuntu1.5) vivid; urgency=medium
* Merge in changes from 2.02~beta2-22ubuntu1.3:
- d/p/arm64-set-correct-length-of-device-path-end-entry.patch: Fixes
booting arm64 kernels on certain UEFI implementations. (LP: #1476882)
- progress: avoid NULL dereference for net files. (LP: #1459872)
- arm64/setjmp: Add missing license macro. (LP: #1459871)
- Cherry-pick patch to add SAS disks to the device list from the ofdisk
module. (LP: #1517586)
- Cherry-pick patch to open Simple Network Protocol exclusively.
(LP: #1508893)
* Cherry-picks to better handle TFTP timeouts on some arches: (LP: #1521612)
- (7b386b7) efidisk: move device path helpers in core for efinet
- (c52ae40) efinet: skip virtual IP devices when enumerating cards
- (f348aee) efinet: enable hardware filters when opening interface
* Update quick boot logic to handle abstractions for which there is no
write support. (LP: #1274320)
-- dann frazier <dannf at ubuntu.com> Wed, 16 Dec 2015 13:31:15 -0700
** Changed in: grub2 (Ubuntu Vivid)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1459872
Title:
using progress mod w/ net files crashes
Status in grub2 package in Ubuntu:
Fix Released
Status in grub2 source package in Trusty:
Fix Released
Status in grub2 source package in Vivid:
Fix Released
Status in grub2 source package in Wily:
Fix Released
Bug description:
[Impact]
If the progress module is loaded, GRUB will crash when loading files over the network. A common scenario where this occurs is when building a GRUB image for EFI netbooting w/ all modules included. MAAS does this when generating it's grubnet EFI binary. MAAS currently works around this by explicitly blacklisting the progress module - but only on arm64 (we'd only observed this on arm64 at the time, and didn't yet know the root cause).
While the easy workaround is to just omit the progress module, it
isn't at all obvious from the crash that progress.mod is the cause.
[Test Case]
The simple case is to create a grub image with *just* the progress module and netboot it. For arm64:
$ grub-mkimage -v -o grubaa64.efi -O arm64-efi -d
/home/dannf/x/usr/lib/grub/arm64-efi progress
Booting the resulting image:
[1] PXE
[2] ubuntu
[3] Shell
[4] Boot Manager
Start: 1
..
Synchronous Exception at 0x0000000FF7C3DDC8
Synchronous Exception at 0x0000000FF7C3DDC8
Synchronous Exception at 0x0000000FF7C3DDC8
Synchronous Exception at 0x0000000FF7C3DDC8
[...]
[Regression Risk]
The upstream fix for this is a pretty surgical fix to check for NULL before dereferencing a pointer.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1459872/+subscriptions
More information about the foundations-bugs
mailing list