[Bug 1548988] Re: please add -fstime patch for snap v2 checks in review tools

Tue Feb 23 22:09:50 UTC 2016

** Description changed:

- [Impact] 
+ [Impact]
  From xenial:

  squashfs-tools (1:4.3-3ubuntu1) xenial; urgency=medium

-   * debian/patches/0005-add-fstime.patch: add -fstime to unsquashfs to 
-     extract the fs superblock information and -fstime to mksquashfs to set 
-     the fs superblock time on create. This is needed to support Ubuntu 
-     Store unpack and repack checks for snappy v2 snaps.
+   * debian/patches/0005-add-fstime.patch: add -fstime to unsquashfs to
+     extract the fs superblock information and -fstime to mksquashfs to set
+     the fs superblock time on create. This is needed to support Ubuntu
+     Store unpack and repack checks for snappy v2 snaps.

  This patch needs to be SRU'd to trusty so that Canonical machines for
  the Ubuntu Store can properly verify snap v2 packages and so that people
  running trusty can verify snap v2 packages locally.

+ [Test Case]
+ Attached is sru-tests.tar.gz that has tests to both show the bug is fixed and some tests for regressions.

- [Test Case]
- The easiest what to test the bug is to check out the review tools and then run them on a v2 snap. Eg:
+ $ schroot -c trusty-amd64 -u root
+ # apt-get install squashfs-tools
+ # su <your username>
+ $ tar -zxvf ./sru-tests.tar.gz
+ $ cd sru-tests
+ $ ./test-regression.sh
+ ...
+ All tests pass
+ 
+ $ ./test-fixes-1548988.sh 
+ Could not determine fstime
+ 
+ but with the fix:
+ $ ./test-fixes-1548988.sh 
+ Parallel unsquashfs: Using 4 processors
+ ...
+ ./snappy-v2_0.1_all.snap: 2704f7c4815713ce75fe6ca83e7782f6e595763f5ec9003dc08a20f358ed90c0c56b571fcd348021ec51386608f2524f82f9d29d073a47b590dacf017bc9da0b
+ /tmp/tmp.LrTJ7UHXnE/repack.snap: 2704f7c4815713ce75fe6ca83e7782f6e595763f5ec9003dc08a20f358ed90c0c56b571fcd348021ec51386608f2524f82f9d29d073a47b590dacf017bc9da0b
+ 
+ SUCCESS: match
+ 
+ 
+ If you also want to see if it works with the review tools, can check out the review tools and then run them on a v2 snap. Eg:

  $ schroot -c trusty-amd64 -u root
  # apt-get install click-reviewers-tools squashfs-tools bzr python3-yaml python3-lxml
  # su <your username>
  $ bzr branch lp:click-reviewers-tools
  $ cd click-reviewers-tools
- $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap
+ $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap # from sru-tests
+ 
  Warnings
  --------
-  - security-snap-v2:squashfs_supports_fstime
- 	could not determine fstime of squashfs
+  - security-snap-v2:squashfs_supports_fstime
+  could not determine fstime of squashfs
  /tmp/snappy-v2_0.1_all.snap: FAIL

- 
  With updated squashfs-tools:
- $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap 
+ $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap
  /tmp/snappy-v2_0.1_all.snap: pass

  or:
  $ PYTHONPATH=./ ./bin/click-review -v /tmp/snappy-v2_0.1_all.snap
  ...
-  - security-snap-v2:squashfs_repack_checksum
- 	OK
+  - security-snap-v2:squashfs_repack_checksum
+  OK
  /tmp/snappy-v2_0.1_all.snap: pass

- I'll add additional instructions for testing squashfs-tools for regressions.
- 
- 
- [Regression Potential] 
+ [Regression Potential]
  The chance of regression is very small because the code that is being added is for non-default options and is only run if specifying the new -fstime option to mksquashfs and unsquashfs. Furthermore this patch exists in xenial with no bugs against it since the upload.
- 

  [Other Info]
  In addition to the above, I compared build logs between unpatched and patched and no new warnings or issues were found.

** Attachment removed: "sru-tests.tar.gz"
   https://bugs.launchpad.net/ubuntu/+source/squashfs-tools/+bug/1548988/+attachment/4579442/+files/sru-tests.tar.gz

** Attachment added: "sru-tests.tar.gz"
   https://bugs.launchpad.net/ubuntu/+source/squashfs-tools/+bug/1548988/+attachment/4579463/+files/sru-tests.tar.gz

** Changed in: squashfs-tools (Ubuntu Trusty)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to squashfs-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1548988

Title:
  please add -fstime patch for snap v2 checks in review tools

Status in squashfs-tools package in Ubuntu:
  Fix Released
Status in squashfs-tools source package in Trusty:
  In Progress

Bug description:
  [Impact]
  From xenial:

  squashfs-tools (1:4.3-3ubuntu1) xenial; urgency=medium

    * debian/patches/0005-add-fstime.patch: add -fstime to unsquashfs to
      extract the fs superblock information and -fstime to mksquashfs to set
      the fs superblock time on create. This is needed to support Ubuntu
      Store unpack and repack checks for snappy v2 snaps.

  This patch needs to be SRU'd to trusty so that Canonical machines for
  the Ubuntu Store can properly verify snap v2 packages and so that
  people running trusty can verify snap v2 packages locally.

  [Test Case]
  Attached is sru-tests.tar.gz that has tests to both show the bug is fixed and some tests for regressions.

  $ schroot -c trusty-amd64 -u root
  # apt-get install squashfs-tools
  # su <your username>
  $ tar -zxvf ./sru-tests.tar.gz
  $ cd sru-tests
  $ ./test-regression.sh
  ...
  All tests pass

  $ ./test-fixes-1548988.sh 
  Could not determine fstime

  but with the fix:
  $ ./test-fixes-1548988.sh 
  Parallel unsquashfs: Using 4 processors
  ...
  ./snappy-v2_0.1_all.snap: 2704f7c4815713ce75fe6ca83e7782f6e595763f5ec9003dc08a20f358ed90c0c56b571fcd348021ec51386608f2524f82f9d29d073a47b590dacf017bc9da0b
  /tmp/tmp.LrTJ7UHXnE/repack.snap: 2704f7c4815713ce75fe6ca83e7782f6e595763f5ec9003dc08a20f358ed90c0c56b571fcd348021ec51386608f2524f82f9d29d073a47b590dacf017bc9da0b

  SUCCESS: match

  If you also want to see if it works with the review tools, can check out the review tools and then run them on a v2 snap. Eg:

  $ schroot -c trusty-amd64 -u root
  # apt-get install click-reviewers-tools squashfs-tools bzr python3-yaml python3-lxml
  # su <your username>
  $ bzr branch lp:click-reviewers-tools
  $ cd click-reviewers-tools
  $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap # from sru-tests

  Warnings
  --------
   - security-snap-v2:squashfs_supports_fstime
   could not determine fstime of squashfs
  /tmp/snappy-v2_0.1_all.snap: FAIL

  With updated squashfs-tools:
  $ PYTHONPATH=./ ./bin/click-review /tmp/snappy-v2_0.1_all.snap
  /tmp/snappy-v2_0.1_all.snap: pass

  or:
  $ PYTHONPATH=./ ./bin/click-review -v /tmp/snappy-v2_0.1_all.snap
  ...
   - security-snap-v2:squashfs_repack_checksum
   OK
  /tmp/snappy-v2_0.1_all.snap: pass

  [Regression Potential]
  The chance of regression is very small because the code that is being added is for non-default options and is only run if specifying the new -fstime option to mksquashfs and unsquashfs. Furthermore this patch exists in xenial with no bugs against it since the upload.

  [Other Info]
  In addition to the above, I compared build logs between unpatched and patched and no new warnings or issues were found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squashfs-tools/+bug/1548988/+subscriptions