[Bug 1567219]

[Aleksandar-rikalo]

(In reply to Ivo Raisr from comment #31)

Thank You for reviewing.

I have fixed all things that you mention. The full patch is attached,
and the new version of tests is also attached.

> 2) When including "tinfl.c", do we want to define "TINFL_HEADER_FILE_ONLY"?
> 20) I don't see any coregrind/Makefile changes to build m_debuginfo/tinfl.c?

In case we use #include "tinfl.c" without defining TINFL_HEADER_FILE_ONLY, we don't need tinfl.c in Makefile.
If we include header only (by defining TINFL_HEADER_FILE_ONLY before #include) then tinfl.c needs to be compiled separately (this solution is applied in rev2 patch). 

> 5) CEnt.data has now non-fixed size. Why CACHE_ENTRY_SIZE is still used in
> various places
> around image.c; for example in alloc_CEnt() and realloc_CEnt()?

CACHE_ENTRY_SIZE is still in use as default (and minimal) size of cache
entry. Larger entries will be allocated in case size of the uncompressed
data is grater than CACHE_ENTRY_SIZE.

> However I don't have any system with toolchain supporting '-gz' at hand.
> I assume you tested on MIPS. Anyone can test on a different architecture or
> distribution?

It seems that nobody has GCC which supports -gz, so the test is useless
for now.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to valgrind in Ubuntu.
https://bugs.launchpad.net/bugs/1567219

Title:
  Valgrind does not support compressed debug info

Status in Ubuntu on IBM z Systems:
  Confirmed
Status in Valgrind:
  Unknown
Status in valgrind package in Ubuntu:
  Confirmed

Bug description:
  == Comment: #0 - Andreas Arnez <arnez at de.ibm.com> - 2016-04-01 12:23:20 ==
  It seems that some Ubuntu debug packages are built with compressed debug info, which is not supported by Valgrind.  In particular I've seen that this even applies to the dynamic loader (when libc6-dbg is installed):

  $ ./vg-in-place /bin/true
  ==5907== Memcheck, a memory error detector
  ==5907== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
  ==5907== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright info
  ==5907== Command: /bin/true
  ==5907== 
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/ld-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/ld-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/ld-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/ld-2.23.so:
  --5907-- Last block truncated in .debug_info; ignoring
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/ld-2.23.so:
  --5907-- parse_CU_Header: is neither DWARF2 nor DWARF3 nor DWARF4
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/libc-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/libc-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/libc-2.23.so:
  --5907-- Ignoring non-Dwarf2/3/4 block in .debug_info
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/libc-2.23.so:
  --5907-- Last block truncated in .debug_info; ignoring
  --5907-- WARNING: Serious error when reading debug info
  --5907-- When reading debug info from /lib/s390x-linux-gnu/libc-2.23.so:
  --5907-- parse_CU_Header: is neither DWARF2 nor DWARF3 nor DWARF4
  ==5907== 
  ==5907== HEAP SUMMARY:
  ==5907==     in use at exit: 0 bytes in 0 blocks
  ==5907==   total heap usage: 0 allocs, 0 frees, 0 bytes allocated
  ==5907== 
  ==5907== All heap blocks were freed -- no leaks are possible
  ==5907== 
  ==5907== For counts of detected and suppressed errors, rerun with: -v
  ==5907== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

  == Comment: #1 - Andreas Arnez <arnez at de.ibm.com> - 2016-04-01 12:26:28 ==
  Note that this issue should apply to all platforms.  It has already been reported for upstream Valgrind, and a patch has been proposed:

    https://bugs.kde.org/show_bug.cgi?id=303877

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1567219/+subscriptions