[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

[Martin Pitt]

Packaging review:
 - Please use 3.0 (quilt) source format for clean and standard patch management.

 - Disabling "make check" (override_dh_auto_test) is a bit sad -- when
running "make check" it fails with "unable to infer compiler target
triple for clang". Is there any way to run the tests with gcc? If not,
should this get a clang build dependency? If that doesn't work, please
add a comment to debian/rules why tests can't/shouldn't be run.

 - W: go-race-detector-runtime source: dep5-copyright-license-name-not-unique (paragraph at line 35)
   Indeed you used "License: Expat" with two different license texts, AFAICS mostly due to including the copyright into it (which shouldn't happen -- that's what Copyright: is for). It's usually best to just say "License: Expat" in all Files: stanzas, and have a separate

  License: expat
    ..blabla long text

  stanza at the bottom, to avoid repetition.

 - There are several missing copyrights in debian/copyright, e. g.
./lib/BlocksRuntime/Block.h has "Copyright 2008-2010 Apple, Inc." and
the license is BSD.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to golang in Ubuntu.
https://bugs.launchpad.net/bugs/1487010

Title:
  please upload new package to reenable go's race detector on wily

Status in golang package in Ubuntu:
  In Progress

Bug description:
  I've built a package that reenables the race detector on wily:

  http://people.canonical.com/~mwh/go-race-detector-runtime/

  This is the first time I've made a package from scratch so it'll
  probably need more than one round of review.

  Previous description follows:

  for example using lp:ubuntu-push/automatic ... and going into
  server/session I get (this was working in vivid and on wily before the
  1.5rc1 upgrade)

  $ go version
  go version go1.5rc1 linux/amd64
  $ go test -race
  # testmain
  runtime.raceinit: __tsan_init: not defined
  runtime.raceinit: __tsan_map_shadow: not defined
  runtime.racefini: __tsan_fini: not defined
  runtime.racemapshadow: __tsan_map_shadow: not defined
  runtime.racemalloc: __tsan_malloc: not defined
  runtime.racegostart: __tsan_go_start: not defined
  runtime.racegoend: __tsan_go_end: not defined
  runtime.raceacquireg: __tsan_acquire: not defined
  runtime.racereleaseg: __tsan_release: not defined
  runtime.racereleasemergeg: __tsan_release_merge: not defined
  runtime.racefingo: __tsan_finalizer_goroutine: not defined
  runtime.RaceDisable: __tsan_go_ignore_sync_begin: not defined
  runtime.RaceEnable: __tsan_go_ignore_sync_end: not defined
  runtime.raceread: __tsan_read: not defined
  runtime.racereadpc: __tsan_read_pc: not defined
  runtime.racewrite: __tsan_write: not defined
  runtime.racewritepc: __tsan_write_pc: not defined
  runtime.racereadrange: __tsan_read_range: not defined
  runtime.racereadrangepc1: __tsan_read_range: not defined
  runtime.racewriterange: __tsan_write_range: not defined
  runtime.racewriterangepc1: __tsan_write_range: not defined
  /usr/lib/go/pkg/tool/linux_amd64/link: too many errors
  FAIL	launchpad.net/ubuntu-push/server/session [build failed]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang/+bug/1487010/+subscriptions