[Bug 1491977] Comment bridged from LTC Bugzilla

[bugproxy]

------- Comment From hegdevasant at in.ibm.com 2015-09-11 06:47 EDT-------
Hello Canonical,

All the patches are accepted in upstream.. Please pull below three
patches..

commit 546174be41c74894126414515644888ed8b31584
Author: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Date:   Wed Sep 2 10:23:21 2015 -0400

update_flash: Fix bad variable issue
Shells like dash throws error if we try to assign string with space
without double quote. ex:
local bug=ML FW830.00 FW830.00
Sample output without this patch:
update_flash -f 01SV840_016_016.img
/usr/sbin/update_flash: 185: local: FW830.00: bad variable name

commit 62dc6d38de177588f205e01cec15b93b3e2b9a30
Author: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Date:   Wed Sep 2 10:26:23 2015 -0400

update_flash: Stop kexec service before starting firmware update
We run 'reboot' call before initiating firmware update. If kexec service
is enabled, then we endup booting into new kernel instead of starting
firmware update.
This patch validates kexec service and if required stops this service
before starting code update.

commit 8ff5144da07985cd84508465007f9031840d4ecd
Author: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Date:   Tue Sep 8 11:33:24 2015 -0400

update_flash: Stop kexec service before starting firmware update on PowerVM LPAR
We run 'reboot' call before initiating firmware update. If kexec service
is enabled, then we endup booting into new kernel instead of starting
firmware update.
Commit 62dc6d38 fix this issue on PowerNV platform.. but missed to fix
PowerVM LPAR.  This patch fixes above described issue on PowerVM LPAR.
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

-Vasant

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to powerpc-ibm-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1491977

Title:
  update_flash fails on Ubuntu in PowerVM mode

Status in powerpc-ibm-utils package in Ubuntu:
  Triaged

Bug description:
  ---Problem Description---
  update_flash (PowerVM mode) from Ubuntu fails with a 'bad variable name'.
    
  ---uname output---
  Linux neo33-2 3.19.0-21-generic #21-Ubuntu SMP Sun Jun 14 19:33:37 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux
   
  Machine Type = type_model=8247-22L
    
  ---Steps to Reproduce---
   # update_flash -f 01SV840_016_016.img 
  /usr/sbin/update_flash: 185: local: FW830.00: bad variable name

  If I comment out line 252 and run it again, things do work (but there
  is checking that doesn't happen in that case)

  #        echo_validate_return_status "$output"

  
  Upstream commit ID :

  commit 546174be41c74894126414515644888ed8b31584
  Author: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
  Date:   Wed Sep 2 10:23:21 2015 -0400

      update_flash: Fix bad variable issue
      
      Shells like dash throws error if we try to assign string with space
      without double quote. ex:
       local bug=ML FW830.00 FW830.00

  
  > [PATCH] update_flash: Stop kexec service before starting firmware update on
  > PowerVM LPAR

  I've posted this patch to upstream today...

  -Vasant

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/powerpc-ibm-utils/+bug/1491977/+subscriptions