[Bug 1459871] Re: arm64 images built w/ setjump module fail w/ license error

[dann frazier]

Here's a pull request against debian's git:

The following changes since commit
f71c8970804848681afe0eb0a597aefb9d4463a2:

  releasing package grub2 version 2.02~beta2-29 (2015-10-13 23:40:21
+0100)

are available in the git repository at:

  https://git.launchpad.net/~dannf/grub2 people/dannf/arm64-setjmp-
license

for you to fetch changes up to 269a263bb6c706329fec0efa0b68d7bd100d4fbc:

  merge patched-people/dannf/arm64-setjmp-license into
people/dannf/arm64-setjmp-license (2015-10-23 16:25:25 -0600)

----------------------------------------------------------------
dann frazier (2):
      arm64/setjmp: Add missing license macro
      merge patched-people/dannf/arm64-setjmp-license into people/dannf/arm64-setjmp-license

 debian/.git-dpm                                    |  4 +--
 debian/changelog                                   |  6 ++++
 .../arm64-setjmp-Add-missing-license-macro.patch   | 33 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 grub-core/lib/arm64/setjmp.S                       |  2 ++
 5 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 debian/patches/arm64-setjmp-Add-missing-license-macro.patch


** Description changed:

- Including the setjmp module in an arm64-efi image will cause it to
- immediately exit with an "incompatible license" error.
+ [Impact]
+ Any ARM64 GRUB image that includes the setjmp module will fail, reporting an "incompatible license" error. Ubuntu doesn't normally include this module in most images. The one exception I know of is MAAS which, by default, includes all modules when generating EFI images. MAAS currently has a hack to blacklist setjmp on arm64 because a fix wasn't available at the time - but I fear other users will try to do the same thing and hit this issue which can be difficult to track down.
  
- http://lists.gnu.org/archive/html/grub-devel/2015-05/msg00150.html
+ [Test Case]
+ PXE boot a grub image on arm64 that includes the setjmp module:
+ 
+ $ grub-mkimage -v -o grubaa64.efi -O arm64-efi -d
+ /usr/lib/grub/arm64-efi setjmp
+ 
+ [Regression Risk]
+ The patch merely adds a license section to the module and it has been tested to work.

** Changed in: grub2 (Ubuntu Trusty)
       Status: New => Confirmed

** Changed in: grub2 (Ubuntu Xenial)
       Status: New => Confirmed

** Changed in: grub2 (Ubuntu Wily)
       Status: New => Confirmed

** Changed in: grub2 (Ubuntu Vivid)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1459871

Title:
  arm64 images built w/ setjump module fail w/ license error

Status in grub2 package in Ubuntu:
  Confirmed
Status in grub2 source package in Trusty:
  Confirmed
Status in grub2 source package in Vivid:
  Confirmed
Status in grub2 source package in Wily:
  Confirmed
Status in grub2 source package in Xenial:
  Confirmed

Bug description:
  [Impact]
  Any ARM64 GRUB image that includes the setjmp module will fail, reporting an "incompatible license" error. Ubuntu doesn't normally include this module in most images. The one exception I know of is MAAS which, by default, includes all modules when generating EFI images. MAAS currently has a hack to blacklist setjmp on arm64 because a fix wasn't available at the time - but I fear other users will try to do the same thing and hit this issue which can be difficult to track down.

  [Test Case]
  PXE boot a grub image on arm64 that includes the setjmp module:

  $ grub-mkimage -v -o grubaa64.efi -O arm64-efi -d
  /usr/lib/grub/arm64-efi setjmp

  [Regression Risk]
  The patch merely adds a license section to the module and it has been tested to work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1459871/+subscriptions