[Bug 1465386] [NEW] Default values for WAIT_STATE are wrong in the upstart wait-for-state job

[Rarylson Freitas]

Public bug reported:

In Ubuntu 14.04, the wait-for-state job uses the env vars
WAIT_STATE="started" or WAIT_STATE="stopped". if the GOAL env var is set
to 'start' or 'stop'.

However, according to the upstart cookbook, the desired states for a
already started/stopped job are 'start/running' and 'stop/waiting'.
Maybe a misunderstood has occurred was the meaning of signals was job
states (for example, after a job reaches the start/running state, it
emits the started signal).

The strange thing is that the waiting/running wait states were proposed
at the first implementations of this job, and not the stopped/started
states: https://lists.ubuntu.com/archives/upstart-
devel/2011-February/001405.html.

This  bug can make some developers to write upstart jobs that return
errors (like the GlusterFS developers, that forgot the
WAIT_STATE="running" condition).

References:

- http://upstart.ubuntu.com/cookbook/#job-states
- http://upstart.ubuntu.com/cookbook/#events-not-states
- https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/1465382

I'm attaching a patch too.

** Affects: upstart (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "wait-for-state.conf.patch"
   https://bugs.launchpad.net/bugs/1465386/+attachment/4415275/+files/wait-for-state.conf.patch

** Summary changed:

- Default values for WAIT_STATE in the upstart wait-for-state job are wrong
+ Default values for WAIT_STATE are wrong in the upstart wait-for-state job

** Package changed: glusterfs (Ubuntu) => upstart (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/1465386

Title:
  Default values for WAIT_STATE are wrong in the upstart wait-for-state
  job

Status in upstart package in Ubuntu:
  New

Bug description:
  In Ubuntu 14.04, the wait-for-state job uses the env vars
  WAIT_STATE="started" or WAIT_STATE="stopped". if the GOAL env var is
  set to 'start' or 'stop'.

  However, according to the upstart cookbook, the desired states for a
  already started/stopped job are 'start/running' and 'stop/waiting'.
  Maybe a misunderstood has occurred was the meaning of signals was job
  states (for example, after a job reaches the start/running state, it
  emits the started signal).

  The strange thing is that the waiting/running wait states were
  proposed at the first implementations of this job, and not the
  stopped/started states: https://lists.ubuntu.com/archives/upstart-
  devel/2011-February/001405.html.

  This  bug can make some developers to write upstart jobs that return
  errors (like the GlusterFS developers, that forgot the
  WAIT_STATE="running" condition).

  References:

  - http://upstart.ubuntu.com/cookbook/#job-states
  - http://upstart.ubuntu.com/cookbook/#events-not-states
  - https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/1465382

  I'm attaching a patch too.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1465386/+subscriptions